fix so mercurial_keyring can work against hg 3.8 after aa73d6a5d9ea
Was already merged in Bitbucket before import, marked as merged by the import user
Merge request reports
Activity
Created originally on Bitbucket by seanfarley (Sean Farley)
This would break compatibility with older versions of Mercurial, I believe.
Created originally on Bitbucket by Mekk (Marcin Kasperski)
This should be fixable so it works both ways, I’ll take a look…
(anybody remembes when cmdtable was introduced? I remember trying it somewhere and backing off as it was not supported on mercurials as present on current distros and PPas…)
Created originally on Bitbucket by Mekk (Marcin Kasperski)
And I suppose the changeset mentioned in the title is https://selenic.com/repo/hg/rev/aa73d6a5d9ea
Created originally on Bitbucket by Mekk (Marcin Kasperski)
… and, for the sake of completeness, as I have more extensions to support, my first instinct is to either write and use cmdtable emulation for old mercurials (likely in mercurial_extension_utils), or if it turns difficult, write another api which would be possible to implement twoways
(as a sidenote: decorators may be cute, but I have cases where it really is more pleasant to separate definition from dcumentation)
Created originally on Bitbucket by Mekk (Marcin Kasperski)
For the sake of experimentation I converted path_pattern (which contrary to keyring is easy to test and which I have nicely tox-ified) to new API. Looks like since mercurial 3.1 it works nicely, but up to (and including) 3.0 some workarounds may be needed. I am to complete work there, then port the approach here.
For example, here is my output on https://bitbucket.org/Mekk/mercurial-path_pattern/commits/9fbe2ec84019fd9194b49d8cfc0d211479246d59
ERROR: py26-hg27: commands failed ERROR: py26-hg29: commands failed ERROR: py27-hg28: commands failed ERROR: py27-hg29: commands failed ERROR: py27-hg30: commands failed py27-hg31: commands succeeded py27-hg32: commands succeeded py27-hg33: commands succeeded py27-hg36: commands succeeded py27-hg37: commands succeeded
Created originally on Bitbucket by Mekk (Marcin Kasperski)
OK, I worked things out. In fact the code below works as incompatibility is about norepo=...,inferrepo=...,optionalrepo=… args. As the code below does not use it, it is in fact quite OK.
Still, I am to apply compatibility layer for future case.
So I will accept this pull request, then tweak it.
Created originally on Bitbucket by Mekk (Marcin Kasperski)
Released as 1.1.0