Skip to content
Snippets Groups Projects

Add keyring backends to demandimport ignores

1 unresolved thread

Without this patch, the extension only works under Python 3.9 if you disable demandimport.

Merge request reports

Merged by Marcin KasperskiMarcin Kasperski 4 years ago (Feb 20, 2021 6:09pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • This caught my attention because I'm attempting to figure out #76 (closed), and I have it working with 3.9.1 with earlier versions of keyring (and failing on 3.7.4 with a later version of keyring). But applying this fix doesn't fix the thing I'm working on. Is it possible that the issue fixed here is platform specific?

    • This fixes the issue described in #76 (closed). My problem was that I was using keyring 21.6.0 (since it's the first version to break), which uses the following backends:

      			"keyring.backends.OS_X",
      			"keyring.backends._OS_X_API",

      IDK if it's the policy of this project to assume the latest underlying keyring package, but this seems easy enough to slip in these couple of lines, and support several recent older versions too. (And maybe update the description to reflect that it's keyring version specific, not python version specific?) I remember seeing mention of renaming the backends in recent documentation, so IDK if there are similar issues with non-macOS platforms too.

    • Please register or sign in to reply
  • mentioned in issue #76 (closed)

  • I am not 100% sure whether this is necessery to blacklist all backends. Still, I suppose that it won't spoil anything too (once the backend is imported, it is to be used), so let it be.

  • mentioned in commit 5d32fee7a07f

  • Matt Harbison mentioned in merge request !18 (merged)

    mentioned in merge request !18 (merged)

Please register or sign in to reply
Loading