Skip to content
Snippets Groups Projects
Commit f5d287d07a2f authored by Pierre-Yves David's avatar Pierre-Yves David :octopus:
Browse files

benchmark: properly deal with problematic http revisions

We use a clear, simple but direct approach to skip test involving http for
problematic revision.
parent f93307cb26e7
No related branches found
No related tags found
No related merge requests found
......@@ -120,7 +120,5 @@
def _setup_repo_type(self, repo_type):
"""setup a hgweb server if we have to"""
self._hgserve = None
if repo_type == 'http' and self.get_asv_rev() in self.get_skip()['hgweb']:
raise NotImplementedError
self.repo_type = repo_type
if repo_type == 'http':
......@@ -125,7 +123,19 @@
self.repo_type = repo_type
if repo_type == 'http':
self._hgserve = HgWeb()
self.hgport = self._hgserve.start(self.hgpath, self.environ)
### skip hgweb for some broken instance:
# we used to skip for f0a851542a05::877185de62^
# pointing at https://bz.mercurial-scm.org/show_bug.cgi?id=5851
# but there is futher issue so 6b0275e5f276^ it is.
#
# should be a BaseTestSuite object
currentrev = self.get_asv_rev()
badhttp = "::(6b0275e5f27696226595c114c9bf034519aaad45^)"
if self._matchrevset(badhttp, currentrev):
msg = "http server may hang for %s" % currentrev
raise NotImplementedError(msg)
else:
self._hgserve = HgWeb()
self.hgport = self._hgserve.start(self.hgpath, self.environ)
def _teardown_repo_type(self):
if self._hgserve is not None:
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment