Skip to content
Snippets Groups Projects
Commit f6b904f554de authored by Pierre-Yves David's avatar Pierre-Yves David :octopus:
Browse files

perfrevlogwrite: factor the title selection out

We are going to reuse the same logic over and over, so we factor it out in its
own function.
parent 99d2ed094099
No related branches found
No related tags found
No related merge requests found
...@@ -124,9 +124,9 @@ ...@@ -124,9 +124,9 @@
key = ('perfrevlogwrite', target, nbrev, source, lazydeltabase) key = ('perfrevlogwrite', target, nbrev, source, lazydeltabase)
return self.getperfdata(key, cmd) return self.getperfdata(key, cmd)
def _run_one_full(self, target, nbrev, source, lazydeltabase=False): def _run_one_id(self, title, target, nbrev, source, lazydeltabase=False):
data = self._run_one(target, nbrev, source, lazydeltabase) data = self._run_one(target, nbrev, source, lazydeltabase)
if data is None: if data is None:
return float('nan') return float('nan')
title = None title = None
for title in data.keys(): for title in data.keys():
...@@ -128,11 +128,11 @@ ...@@ -128,11 +128,11 @@
data = self._run_one(target, nbrev, source, lazydeltabase) data = self._run_one(target, nbrev, source, lazydeltabase)
if data is None: if data is None:
return float('nan') return float('nan')
title = None title = None
for title in data.keys(): for title in data.keys():
if title.startswith('total time'): if title.startswith(title):
break break
if title is None: if title is None:
return float('nan') return float('nan')
return data[title]['median'] return data[title]['median']
...@@ -134,8 +134,11 @@ ...@@ -134,8 +134,11 @@
break break
if title is None: if title is None:
return float('nan') return float('nan')
return data[title]['median'] return data[title]['median']
def _run_one_full(self, target, nbrev, source, lazydeltabase=False):
return self._run_one_id('total time', target, nbrev, source, lazydeltabase)
@params_as_kwargs @params_as_kwargs
def track_perfrevlogwrite_changelog(self, nbrev, *args, **kwargs): def track_perfrevlogwrite_changelog(self, nbrev, *args, **kwargs):
return self._run_one_full('--changelog', nbrev, 'full', return self._run_one_full('--changelog', nbrev, 'full',
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment