- Apr 28, 2019
-
-
Pierre-Yves David authored
The existing discovery test are now using the new roles information. To keep the compatibility witht he older class structure. We are using the `benchmark_name` feature to keep the same name. We'll probably want to use the very same feature to rename all test later into something more sensible. However, as a side effect, this means we are dropping the "same" variant of the subset/super set test. So ASV will be confused by the params value change... <sigh>. Important note: for this discovery to work, benchmark now needs to be have an upgraded reference.
-
- Apr 27, 2019
-
-
Pierre-Yves David authored
benchmark test can now "easily" use the new role information. A `BaseExchangeTimeSuite` subclass can use the `role_action` and `role_subtype` to declare the role the class is using. Then decorate the class with `@setup_role` to make sure the parameters variants are properly set. Finally the appropriate data can we accessed through the `role_data` property.
-
Pierre-Yves David authored
We need this information to be available to the benchrepo code before we can use it.
-
- Apr 28, 2019
-
-
Pierre-Yves David authored
We are introduce new important configuration data, we should make sure the upgrade makes it available.
-
Pierre-Yves David authored
The roles are important we should include them in order to be able to use them.
-
Pierre-Yves David authored
The goal of this section is to provide a more flexible way to specify target of exchange benchmark. We start small and will add more information later. In the same way, the code to actually use it will land in later changesets.
-
Pierre-Yves David authored
Now that the upgrade script write them one level lower, we read it at that level. For now, it is simple to keep compatibility with the older form. So we keep it.
-
- Apr 27, 2019
-
-
Pierre-Yves David authored
The script can now be used to update the partial-sets information in the `.benchrepo` of the reference. This will prove useful as we introduce more partial variant (current target, the discovery test). note: the script is adding the data at the root level, so not the level the code currently expect. See next changeset for a fix.
-
Pierre-Yves David authored
Given the level of the "benchmark-variables", it seems more appropriate to have the partial-sets at the same level. We start with mentioning that in a comment and then we will see if we can do something about it.
-
- Apr 28, 2019
-
-
Pierre-Yves David authored
Before this change, running upgrade-reference could change the repository-prefix when new version were adding new repository format key. This change is not necessary (see inline comment) and has various anoying side effect (eg: requires a upload/download unchanged file again).
-
Pierre-Yves David authored
We'll add more update to these data sooner. We move the initialization in an independent commit for clarity.
-
- Apr 27, 2019
-
-
Pierre-Yves David authored
Explicitly detecting this older format will help use do have improve behavior when upgrading a reference repository that already have a "repo-prefix" entry.
-
- Apr 28, 2019
-
-
Pierre-Yves David authored
This test will come handy as we modify the script more.
-
Pierre-Yves David authored
That entry is an implementation details, best to no longer rely on it.
-
- Apr 27, 2019
-
-
Pierre-Yves David authored
This carries the meaning better. For now we only renamed things in the code.
-
Pierre-Yves David authored
Small refactoring to clarify the code.
-
Pierre-Yves David authored
Having both `update-reference-config` and `update-benchrepo` is confusing. So we rename `update-benchrepo`. `update` is changed to `upgrade` to clarify that this is meant to move from an older version to a newer one. And `benchrepo` is changed to `reference`, the fact it touches `benchrepo` is mostly an implementation details, the main argument is a `*-reference.tar` file.
-
Pierre-Yves David authored
This can't hurt and make things a bit clearer.
-
Pierre-Yves David authored
The fact we use a hash of anything is an implementation details. In most case, directly using "repo-prefix" is what one should do. We implement that in the parsing code.
-
Pierre-Yves David authored
This is the information this attribute is meant to carry. Using it make things more robust and clarify things.
-
Pierre-Yves David authored
This make sure it is available for those who need it without being required to initialize the object. This will be useful as we migrate exchange tests from the "old way" (clone_path) to the "new way" (role based), see later changeset for details.
-
Pierre-Yves David authored
The debug command scope is not stable and impact the result. We should use the `perfdiscovery` command instead. The current main limitation for the `perfdiscovery` command right now is the fact we don't make is available for revision before it was introduced (even if it should be compatible).
-
Pierre-Yves David authored
This is not a long doc, but should help to navigate the code.
-
Pierre-Yves David authored
This is not a long doc, but should help to navigate the code.
-
Pierre-Yves David authored
The function gather existing code to compute a partial repository path for a given partial version of the main repository. This will be useful later for a more flexible access to partials during discovery.
-
Pierre-Yves David authored
The strip is an implementation detail. The partial_key seems a clearer name. (note: I am not sure about the "partial" part, but I could not find any better).
-
Pierre-Yves David authored
The new name have been around for 1 years, let us stop hacking the old name back. This will requires people to reclone, however will come in a larger wagon that will requires people to reclone anyway.
-
Pierre-Yves David authored
In some situation, the tear down might try to access an attribute not initialized yet. This is annoying since this usually hide the initial error. To avoid that, we set the default attribute value on the class to make sure the tear down find an appropriate value.
-
- Mar 30, 2019
-
-
Pierre-Yves David authored
If no revision is checkout, the "update" variant of the test will fail since there are no file to update. Before this change, the error was quite obscure: no file name was return, as a result the filepath was just the repo directory and `open(…)` call failed. Now we explicitly detect the error and warn about it. I am not sure what error should be raised, So I am going for a classical ValueError.
-
Pierre-Yves David authored
-
- Apr 24, 2019
-
-
Pierre-Yves David authored
Some of the repository script now rely on asv being available.
-
- Mar 30, 2019
-
-
Pierre-Yves David authored
Otherwise the subscript won't use the virtual env content.
-
Pierre-Yves David authored
-
Pierre-Yves David authored
Same logic as for the previous changeset. Since multiple variant share the same idea, we need so distinct them or horrible things will happens.
-
Pierre-Yves David authored
-
- Apr 24, 2019
-
-
Pierre-Yves David authored
-
Pierre-Yves David authored
-
- Apr 12, 2019
-
-
Raphaël Gomès authored
-
- Apr 06, 2019
-
-
Raphaël Gomès authored
This change was forgotten in 33ba3b5df38e during the draft phase.
-
- Apr 05, 2019
-
-
Raphaël Gomès authored
Most failure cases have to be covered basically end-to-end, so we might as well test the entire script. Moreover, failures would be easy to pinpoint since we are testing a single condition every time.
-