Skip to content
  • Matt Harbison's avatar
    phabricator: introduce a very simple dialog for posting reviews · fefc1907fc23
    Matt Harbison authored
    My initial attempt at this was to copy/paste/modify the ReviewBoard dialog, but
    I like the email dialog better- it doesn't have to manage a worker thread, and
    it doesn't attempt parse out errors to display a message box.  Therefore, this
    is a copy and simplify of the email dialog.  Long term, I'd like to add the
    preview tab back in based on `hg export`, and add controls to be able to query
    the server for, and specify reviewers.
    
    There are really only 2 other options: confirm and amend.  Confirm doesn't make
    a lot of sense for the GUI, and amend is probably desired the vast majority of
    the time, so I'm punting on that for now.
    
    The icon is Apache 2.0 licensed from wikimedia.[1]
    
    [1] https://commons.wikimedia.org/wiki/File:Wikimedia_Phabricator_logo_unpadded.svg
    fefc1907fc23