Special Characters in remote passwords breaking parsing
Created originally on Bitbucket by Reanmachine (Aren Blondahl)
I'm really sorry if this was posted already, I could not find an issue for it.
When passwords for remote urls have special characters, namely #
the url parsing algorithm breaks and assumes the user:pass before the @ in the url is actually the port. So given an example:
- username: tortoise
- password: iheart#hg
The remote url should be:
https://tortoise:iheart#hg@someserver.com/some/repo
This gets parsed to:
- Host: tortoise
- Port: iheart
The rest gets dropped. Even with a properly url-encoded password this still breaks the url parsing and saves incorrectly.
This functionality worked in TortoiseHG 1.X.X