Behaviour ExcelWriter changed from 1.2.3 -> 1.3.7
Created originally on Bitbucket by hjunes (Heikki Junes)
I have been using ExcelWriter following the instructions from page
http://packages.python.org/openpyxl/usage.html#write-a-workbook
However, in version 1.3.7 after applying changeset 0707d153e271, these instruction can no longer be followed:
Below is an example, first one succeeds while the second one fails:
{{{ #!python
def test_excel_writer_after_style_updates(): dest_filename = 'excelwriter.xlsx' wb = Workbook() ws = wb.worksheets[0] ws.cell('A1').value = '1%'
ew = ExcelWriter(workbook = wb)
ew.save(filename = dest_filename)
def test_excel_writer_before_style_updates(): dest_filename = 'excelwriter.xlsx' wb = Workbook()
ew = ExcelWriter(workbook = wb)
ws = wb.worksheets[0]
ws.cell('A1').value = '1%'
ew.save(filename = dest_filename)
}}}
The reason is that after ExcelWriter is created:
{{{ #!python
def __init__(self, workbook):
self.workbook = workbook
-
self.style_writer = StyleWriter(self.workbook)
}}}
style_writer is no longer updated.
Is this desired behaviour, or should the changes below be reverted?
{{{ #!python
def write_data(self, archive):
"""Write the various xml files into the zip archive."""
# cleanup all worksheets
shared_string_table = self._write_string_table(archive)
-
style_writer = StyleWriter(self.workbook) archive.writestr(ARC_CONTENT_TYPES, write_content_types(self.workbook)) archive.writestr(ARC_ROOT_RELS, write_root_rels(self.workbook)) archive.writestr(ARC_WORKBOOK_RELS, write_workbook_rels(self.workbook))
@@ -64,10 +64,10 @@ archive.writestr(ARC_CORE, write_properties_core(self.workbook.properties)) archive.writestr(ARC_THEME, write_theme())
-
archive.writestr(ARC_STYLE, style_writer.write_table())
-
archive.writestr(ARC_STYLE, self.style_writer.write_table()) archive.writestr(ARC_WORKBOOK, write_workbook(self.workbook))
-
self._write_worksheets(archive, shared_string_table, style_writer)
-
self._write_worksheets(archive, shared_string_table, self.style_writer)
def _write_string_table(self, archive): }}}
Heikki
Attachments: changes3.bundle