Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • O openpyxl
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 282
    • Issues 282
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 7
    • Merge requests 7
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

Due to a massive storm of spam, registration on this instance now requires explicit administrator approval. Sorry for the added friction, we're also looking into automatic filtering options.

  • openpyxl
  • openpyxl
  • Merge requests
  • !110

Tokenizer improvements

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Bitbucket Importer requested to merge bitbucket/merged-pr-110 into branch/2.4 Feb 09, 2016
  • Overview 1
  • Commits 3
  • Pipelines 0
  • Changes 5

Created originally on Bitbucket by felipeochoa (Felipe)

Was already merged in Bitbucket before import, marked as merged by the import user

Tokenizer improvements

(Closes issue #582 (closed))

This PR addresses most of the issues from issue #582 (closed). Specifically, the following changes are in here:

  • #GETTING_DATA is now recognized as a valid error code

  • Scientific notation now accepts both capital and lowercase E

  • Tokenizer.parse() is renamed to Tokenizer._parse() and is now called automatically upon creating a Tokenizer instance. Client code can now simply do:

    tok = Tokenizer(formula) for token in tok.items: # ...

  • The Tokenizer.parse_* have similarly been renamed to Tokenizer._parse_* and are now private

  • Updates DefinedName to use the new tokenizer pattern

Note: I wasn't able to get tox tests running on my Windows machine. I tested under Python 3.4, which I think should be enough, given these changes are unlikely to introduce Py 2 vs. 3 issues or binary issues.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: bitbucket/merged-pr-110