Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openpyxl
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 236
    • Issues 236
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 3
    • Merge requests 3
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • openpyxl
  • openpyxl
  • Merge requests
  • !112

Closed
Created Feb 12, 2016 by Bitbucket Importer@bitbucket_importerOwner
  • Report abuse
Report abuse

Some performance fixes

  • Overview 1
  • Commits 0
  • Changes 0

Created originally on Bitbucket by Blackeagle52 (Peter Pul)

Changesets for this Pull Request have not been imported, because it had been already declined on Bitbucket. Marked as closed by the import user.

  • Removed if topLeftCell is not None, as it is obsolute with the if before
  • Worksheet has no self._hyperlinks
  • Added top left cell check, and replaced min_row/max_row/min_col/max_col check with using calculate dimension, loops only once over all cells, instead of two times, with very large files.
  • Removed calling the min_row and max_row properties within columns, with very expensive with very large Excel files
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: bitbucket/declined-pr-112