Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • O openpyxl
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 283
    • Issues 283
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 7
    • Merge requests 7
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • openpyxl
  • openpyxl
  • Merge requests
  • !143

Fix in `DefinedName.destinations` : changed to yield either quoted or notquoted sheet name (#714).

  • Review changes

  • Download
  • Patches
  • Plain diff
Closed Bitbucket Importer requested to merge bitbucket/declined-pr-143 into branch/default Oct 30, 2016
  • Overview 1
  • Commits 0
  • Pipelines 0
  • Changes -

Created originally on Bitbucket by fumitoh (fumito hamamura)

Changesets for this Pull Request have not been imported, because it had been already declined on Bitbucket. Marked as closed by the import user.

In the previous code below, when a defined name refers to "'Sheet 1'!$A$1", None is returned as the first element of the tuple returned from a call to the generator destinations. m.group('quoted') instead of m.group('notquoted') should be returned in such cases.

#!python

# defined_name.py, line 133
    @property
    def destinations(self):
        if self.type == "RANGE":
            tok = Tokenizer("=" + self.value)
            for part in tok.items:
                if part.subtype == "RANGE":
                    m = SHEETRANGE_RE.match(part.value)
                    yield m.group('notquoted'), m.group('cells')
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: bitbucket/declined-pr-143