Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openpyxl
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 243
    • Issues 243
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 3
    • Merge requests 3
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • openpyxl
  • openpyxl
  • Merge requests
  • !265

Merged
Created Jul 04, 2018 by Bitbucket Importer@bitbucket_importerOwner

MergedCells are only created for the purpose of writing.

  • Overview 3
  • Commits 1
  • Changes 4

Created originally on Bitbucket by mschieder (Magnus Schieder)

Was already merged in Bitbucket before import, marked as merged by the import user

See https://bitbucket.org/openpyxl/openpyxl/pull-requests/261/fix-for-missing-borders/diff

Now the MergedCells are only created for the purpose of writing, so they can't disturb any other parts of openpyxl.

test_style_assignment in openpyxl/reader/tests test_excel.py

Saving the border style to the top-left cell will create a new border style for that cell.

Old border style of the top-left cell:

<border>
  <left style="mediumDashed">
    <color theme="6"/>
  </left>
  <right/>
  <top style="mediumDashed">
     <color theme="6"/>
  </top>
  <bottom/>
  <diagonal/>
</border>

New border style of the top-left cell:

<border>
  <left style="mediumDashed">
    <color theme="6"/>
  </left>
  <right style="mediumDashed">
    <color theme="6"/>
  </right>
  <top style="mediumDashed">
    <color theme="6"/>
  </top>
  <bottom style="mediumDashed">
    <color theme="6"/>
  </bottom>
  <diagonal/>
</border>

The old border style is not deleted, the number of border styles (len(wb._borders)) is higher.
In this test there is only one style for merge-cells and therefore one additional border.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: bitbucket/merged-pr-265