Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openpyxl
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 248
    • Issues 248
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 5
    • Merge requests 5
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

April 05-07 - Mercurial Paris Conference 2023 - One day of workshop dedicated to Heptapod and Mercurial usage and workflow. There are still places available for both workshops and talks!

  • openpyxl
  • openpyxl
  • Merge requests
  • !286

Fix disjoint cellrange calculation

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Bitbucket Importer requested to merge bitbucket/merged-pr-286 into branch/2.5 Oct 31, 2018
  • Overview 1
  • Commits 4
  • Pipelines 0
  • Changes 2

Created originally on Bitbucket by tehhowch (Benjamin Hauch)

Was already merged in Bitbucket before import, marked as merged by the import user

  • Add additional cases to disjoint tests

    • Highlights issue with existing isdisjoint implementation
  • Update isdisjoint calculation

  • Use cached title variable

  • Update docstrings to improve clarity

    • Fix some punctuation / grammar errors
    • Add missing backtick formatter
    • Rephrase the docstring for union to clarify what it does
    • Update type hints for method arguments & return values

Closes https://bitbucket.org/openpyxl/openpyxl/issues/1116/erroneous-behavior-of-cellrange-isdisjoint

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: bitbucket/merged-pr-286