Skip to content

worksheet page setup modified

Bitbucket Importer requested to merge bitbucket/merged-pr-34 into branch/2.2

Created originally on Bitbucket by jphuart (jean pierre huart)

Was already merged in Bitbucket before import, marked as merged by the import user

worksheet page setup modified to follow the same logic of the worksheet properties and to consider all available parameters.

What is proposed here is done keeping compatibility with the previous versions keeping the worksheet.page_setup as the combination of PageSetup and PrintOptions under it. But splitting the 2 will make code simplier, but will break legacy. Maybe it can be better managed than what I've done.

Small detail I'm not proud of it is the 'untuple' function in module. It has been added to pass a series of tests using saved xlsx files that contains this parameters as tuples. I'm surprised they work correctly because I've the impression they don't follow the schema constraints.

Merge request reports