Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openpyxl
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 242
    • Issues 242
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 3
    • Merge requests 3
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • openpyxl
  • openpyxl
  • Merge requests
  • !362

Merged
Created Dec 09, 2019 by Bitbucket Importer@bitbucket_importerOwner

Fix error when loading workbooks containing links that reference merged cells

  • Overview 7
  • Commits 6
  • Changes 4

Created originally on Bitbucket by Eiríkur Torfason

Was already merged in Bitbucket before import, marked as merged by the import user

We at GRID have come across .xlsx files that fail to load due to the issue described in #1260

This PR attempts to fix the issue.

  • In bind_hyperlinks, check if ref points to a MergedCell. If so, place link on the top-left cell of the merged range.
  • Extend test_merged_hyperlinks by adding a hyperlink pointing to a merged cell in complex-styles-worksheet.xml, then asserting that the link is placed on the top-left cell.

Locally, the tox tests are green across the board except for the pypy3 target that fails while installing dependencies.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: bitbucket/merged-pr-362