Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O openpyxl
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 233
    • Issues 233
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • openpyxl
  • openpyxl
  • Merge requests
  • !387

Fix reading rows with skipped reference attribute

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Baudouin Giard requested to merge topic/3.0/skipped-r into branch/3.0 Dec 18, 2020
  • Overview 2
  • Commits 1
  • Pipelines 2
  • Changes 2

Resolves: #1571 (closed)

Some Excel files generated with third-party libraries such as SpreadsheetGear - there could be other, skip the "r" attribute on "c" tags within rows. Excel seems to put this attribute on every cell, but I couldn't find any evidence that the standard commands it.

openpyxl is not expecting these attributes to be skipped, so the result is that we end up with an invalid parsed row.

To fix this, when we get coordinates, make sure the column number gets assigned to col_counter so the reader always knows which cell it has been reading last.

--HG-- branch : 3.0

Edited Jan 07, 2021 by Baudouin Giard
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: topic/3.0/skipped-r