Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
evolve-native-test
Manage
Activity
Members
Labels
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Raphaël Gomès
evolve-native-test
Commits
a346b164
Commit
a346b164
authored
6 years ago
by
Pierre-Yves David
Browse files
Options
Downloads
Patches
Plain Diff
topic: allow '.' in topic names
This is also commonly used.
parent
af998193
No related branches found
Branches containing commit
Tags
8.0.0
Tags containing commit
No related merge requests found
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
CHANGELOG
+2
-0
2 additions, 0 deletions
CHANGELOG
hgext3rd/topic/__init__.py
+2
-2
2 additions, 2 deletions
hgext3rd/topic/__init__.py
tests/test-topic.t
+3
-3
3 additions, 3 deletions
tests/test-topic.t
with
7 additions
and
5 deletions
CHANGELOG
+
2
−
0
View file @
a346b164
...
...
@@ -18,6 +18,8 @@
* fixed issue 5833 and 5832
* topic: restring name to letter, '-', '_' and '.'
7.3.0 -- 2018-03-21
---------------------
...
...
This diff is collapsed.
Click to expand it.
hgext3rd/topic/__init__.py
+
2
−
2
View file @
a346b164
...
...
@@ -594,6 +594,6 @@
# Have some restrictions on the topic name just like bookmark name
scmutil
.
checknewlabel
(
repo
,
topic
,
'
topic
'
)
rmatch
=
re
.
match
(
br
'
[\w
\-
]+
'
,
topic
)
rmatch
=
re
.
match
(
br
'
[
-_.
\w]+
'
,
topic
)
if
not
rmatch
or
rmatch
.
group
(
0
)
!=
topic
:
helptxt
=
_
(
"
topic names can only consist of alphanumeric,
'
-
'"
...
...
@@ -598,6 +598,6 @@
if
not
rmatch
or
rmatch
.
group
(
0
)
!=
topic
:
helptxt
=
_
(
"
topic names can only consist of alphanumeric,
'
-
'"
"
and
'
_
'
characters
"
)
"
'
_
'
and
'
.
'
characters
"
)
raise
error
.
Abort
(
_
(
"
invalid topic name:
'
%s
'"
)
%
topic
,
hint
=
helptxt
)
compat
.
startpager
(
ui
,
'
topics
'
)
...
...
This diff is collapsed.
Click to expand it.
tests/test-topic.t
+
3
−
3
View file @
a346b164
...
...
@@ -117,8 +117,8 @@
$
hg
topic
'
a12#45
'
abort:
invalid
topic
name:
'
a12#45
'
(
topic
names
can
only
consist
of
alphanumeric
,
'
-
'
and
'
_
'
characters
)
(
topic
names
can
only
consist
of
alphanumeric
,
'
-
'
'
_
'
and
'
.
'
characters
)
[
255
]
$
hg
topic
'
foo bar
'
abort:
invalid
topic
name:
'
foo bar
'
...
...
@@ -121,8 +121,8 @@
[
255
]
$
hg
topic
'
foo bar
'
abort:
invalid
topic
name:
'
foo bar
'
(
topic
names
can
only
consist
of
alphanumeric
,
'
-
'
and
'
_
'
characters
)
(
topic
names
can
only
consist
of
alphanumeric
,
'
-
'
'
_
'
and
'
.
'
characters
)
[
255
]
this
is
trying
to
list
topic
names
...
...
@@ -130,7 +130,7 @@
$
hg
topic
'
*12 B23
'
abort:
invalid
topic
name:
'
*12 B23
'
(
topic
names
can
only
consist
of
alphanumeric
,
'
-
'
and
'
_
'
characters
)
(
topic
names
can
only
consist
of
alphanumeric
,
'
-
'
'
_
'
and
'
.
'
characters
)
[
255
]
Test
commit
flag
and
help
text
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment