Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • Tryton Tryton
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 707
    • Issues 707
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 54
    • Merge requests 54
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • External wiki
    • External wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • TrytonTryton
  • TrytonTryton
  • Issues
  • #4746
Closed
Open
Issue created May 11, 2015 by Nicolas Évrard@nicoe👾Owner

sale_extra design makes mandatory the use of the same fields on sale.extra and sale.extra.line

Due to the fact that the same pattern is passed to both sale.extra and sale.extra.line in MatchMixin (http://hg.tryton.org/trytond/file/bfc6b4989490/trytond/model/match.py#l12) there is a getattr that will fail if both model do not define the same fields (there will be an AttributeError).

I wonder if defining a method 'get_pattern' taking a sale in sale.extra and a line in sale.extra.line would not be a good solution.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking