Skip to content

Fixed: Enter scripts would stack repeatedly in hubs each time a map was visted...

Ru5tK1ng requested to merge topic/default/hub-enter-script into branch/default

In offline mode because the player is spawned in during P_SetupLevel, the thinkers associated with ACS are destroyed when DestoryMostThinkers is called during G_UnSnapshotLevel. However, online spawning is handled differently and the ACS thinkers are present when the player is finally spawned into the map far after the snapshot has been serialized and unpacked. As a result, the extra thinker is serialized when the level is snapshot after a level change and the process repeats itself causing an extra thinker to be added every time. I suspect this is the cause of random crashes in large hub games online. If a mod is running a fair amount of scripts that restart for every player across maps, it is no surprise things so south when thinkers stack for every player.

Merge request reports