Skip to content

Fix memory leak allreduce in increments

Bitbucket Importer requested to merge bitbucket/merged-pr-89 into branch/default

Created originally on Bitbucket by paugier (Pierre Augier)

Was already merged in Bitbucket before import, marked as merged by the import user

Fixes issue #29 (closed) (for CPython 3.7.0 and 3.7.1).

Note that other uses of allreduce are for integers and it seems that there is no memory leak in this case (or very small). Anyway, this problem has been solved in CPython 3.7.2, so I don’t think it’s worth it to do much more on this problem.

The main memory leak was for increments and it should be solved with this PR. We know that there should be another similar case in fluidfft, which could be fixed the same way, but another strategy would be to use CPython == 3.6 or >= 3.7.2.

  • Fix memory leak allreduce +
  • Improve strat/outputs

Merge request reports