Skip to content
Snippets Groups Projects
  • Georges Racinet's avatar
    e5a54fefe3f0
    bootstrap: demo CommitService servicer tested with pytest · e5a54fefe3f0
    Georges Racinet authored
    We use the `pytest-grpc` helpers.
    
    This implements only the `FindCommit` RPC call, but in a complete
    manner.
    
    This raises several questions:
    
    - for now, we have a single `servicer` module, but Gitaly has many
      services:  How shall we organize our code?
    - the fixtures for gRPC server have the module scope. Shall we have
      such a fixture for each service?
    - will we be able to create commits directly with the Gitaly API in
      the future?
    - do we want to separate the tests in several layers, ie those that
      don't need a gRPC server (unit-testing the `changectx_to` functions)
      and those that do?
    e5a54fefe3f0
    History
    bootstrap: demo CommitService servicer tested with pytest
    Georges Racinet authored
    We use the `pytest-grpc` helpers.
    
    This implements only the `FindCommit` RPC call, but in a complete
    manner.
    
    This raises several questions:
    
    - for now, we have a single `servicer` module, but Gitaly has many
      services:  How shall we organize our code?
    - the fixtures for gRPC server have the module scope. Shall we have
      such a fixture for each service?
    - will we be able to create commits directly with the Gitaly API in
      the future?
    - do we want to separate the tests in several layers, ie those that
      don't need a gRPC server (unit-testing the `changectx_to` functions)
      and those that do?