Skip to content
Snippets Groups Projects
  • Georges Racinet's avatar
    ff6feb0a
    Gitaly Comparison test_find_commits: rewrote with RpcHelper · ff6feb0a
    Georges Racinet authored
    Now it compares the entire streams of responses and not just
    lists of commit ids. That being said, it's easy to make a
    test irrelevant with a bug that would have both Mercurial
    and Git return empty responses.
    
    Had to shoehorn somewhat the switch to sorting mode and back,
    using a custom attribute on `rpc_helper`, but that still works.
    
    Additional remarks:
    
    - if a changeset user is `testuser`, then Git puts `none@none` for
      the email address.
    - some assertions are now self-explanatory, we need less comments
    ff6feb0a
    History
    Gitaly Comparison test_find_commits: rewrote with RpcHelper
    Georges Racinet authored
    Now it compares the entire streams of responses and not just
    lists of commit ids. That being said, it's easy to make a
    test irrelevant with a bug that would have both Mercurial
    and Git return empty responses.
    
    Had to shoehorn somewhat the switch to sorting mode and back,
    using a custom attribute on `rpc_helper`, but that still works.
    
    Additional remarks:
    
    - if a changeset user is `testuser`, then Git puts `none@none` for
      the email address.
    - some assertions are now self-explanatory, we need less comments