Skip to content
Snippets Groups Projects
Commit 2ddf34a6 authored by Georges Racinet's avatar Georges Racinet
Browse files

ref service: updated comment about tags

- decided to use the 'SPEC' marker wherever what's expected is
  not clear. Does not imply a formal specification can really
  be found.
- tagtype() uses caches, so the comment was either obsolete
  or overblown.
parent 5081b184
No related branches found
No related tags found
No related merge requests found
......@@ -89,7 +89,7 @@
request: FindAllTagNamesRequest,
context) -> FindAllTagNamesResponse:
repo = self.load_repo(request.repository)
# TODO (inquiry) it's not clear whether GitLab actually expect the
# TODO SPEC it's not clear whether GitLab actually expect the
# tags to be in any ordering. At a quick glance it doesn't, but
# maye we'll end up with confused users because it'd make no sense
# in the UI.
......@@ -93,8 +93,6 @@
# tags to be in any ordering. At a quick glance it doesn't, but
# maye we'll end up with confused users because it'd make no sense
# in the UI.
# TODO we shouldn't have local tags on Heptapod servers, but it
# would be better to have an efficient way to filter them out.
for chunk in chunked(t for t in repo.tags()
if repo.tagtype(t) not in EXCLUDED_TAG_TYPES):
yield FindAllBranchNamesResponse(names=chunk)
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment