Gitaly Comparison test harness: fixing Gitaly bin_dir
In case the `gitaly` executable is to be found in a subdirectory of `GITALY_INSTALL_DIR`, then that same subdirectory has to be provided as the `bin_dir` configuration item, so that Gitaly can find all its non-ruby bundled executables, notably the bundled Git. It was working until now because Gitaly falls back to a system-wide Git if the specified one is not found, whose version is acceptable in CI because the `heptapod-gitaly` base image is itself based on the `heptapod-base` image, which provides the Git version generally accepted by the target GitLab version. Since there is no doubt as to where the `gitaly` executable is supposed to sit, we're only testing one possibility (minimal change to keep the diff understable, to be refactored).
parent
0c1ed47d
No related branches found
No related tags found
Loading
Please register or sign in to comment