Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
hgitaly
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Model registry
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
heptapod
hgitaly
Commits
67aeb0d6
Commit
67aeb0d6
authored
4 years ago
by
Georges Racinet
Browse files
Options
Downloads
Patches
Plain Diff
Dev FAQ: advice to focuse on comparison in tests with Gitaly
parent
68bfa143
No related branches found
Branches containing commit
No related tags found
Tags containing commit
1 merge request
!45
Gitaly comparison tests: option to skip and documentation
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
README.md
+6
-0
6 additions, 0 deletions
README.md
with
6 additions
and
0 deletions
README.md
+
6
−
0
View file @
67aeb0d6
...
...
@@ -102,6 +102,12 @@
common code in a helper function made available for both. The question is if
it is worth the effort.
Finally, comparison tests should focus on the fact that Gitaly and HGitaly
results agree, not on what they contain. In the above example,
a comparison for
`FindAllBranchNames`
could simply assert equality of the
returned sets of branch names. This is a bit less cumbersome, and easier
to maintain.
### How to run the tests with coverage of the Gitaly comparison tests
```
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment