Skip to content
Snippets Groups Projects
Commit d2f4bb85 authored by Georges Racinet's avatar Georges Racinet
Browse files

test_commit: readability improvement

parent 49370cb9
No related branches found
No related tags found
No related merge requests found
......@@ -12,6 +12,6 @@
from ..stub.shared_pb2 import Repository
def test_default_branch(grpc_channel, server_repos_root):
def test_find_commit(grpc_channel, server_repos_root):
grpc_stub = CommitServiceStub(grpc_channel)
repo_path = server_repos_root / 'repo1'
......@@ -16,5 +16,6 @@
grpc_stub = CommitServiceStub(grpc_channel)
repo_path = server_repos_root / 'repo1'
grpc_repo = Repository(relative_path='repo1')
wrapper = LocalRepoWrapper.init(repo_path,
config={b'extensions': {b'topic': b''}}
)
......@@ -31,9 +32,7 @@
parent=ctx,
message="Foo deux\n\nA very interesting bar")
request = FindCommitRequest(
repository=Repository(relative_path='repo1'),
revision=ctx.hex())
request = FindCommitRequest(repository=grpc_repo, revision=ctx.hex())
response = grpc_stub.FindCommit(request)
commit = response.commit
......@@ -44,9 +43,7 @@
assert commit.author.email == b"hgitaly@heptapod.test"
assert commit.author.date.seconds == int(now)
request = FindCommitRequest(
repository=Repository(relative_path='repo1'),
revision=ctx2.hex())
request = FindCommitRequest(repository=grpc_repo, revision=ctx2.hex())
response = grpc_stub.FindCommit(request)
commit2 = response.commit
......@@ -58,9 +55,8 @@
# TODO check with two parents, it'd be nice to have a helper to create
# merge commits very quickly
request = FindCommitRequest(
repository=Repository(relative_path='repo1'),
revision=b'branch/default')
request = FindCommitRequest(repository=grpc_repo,
revision=b'branch/default')
response = grpc_stub.FindCommit(request)
assert response.commit == commit2
......@@ -68,12 +64,11 @@
message="in topic",
topic='antelope',
parent=ctx)
request = FindCommitRequest(
repository=Repository(relative_path='repo1'),
revision=b'topic/default/antelope')
request = FindCommitRequest(repository=grpc_repo,
revision=b'topic/default/antelope')
response = grpc_stub.FindCommit(request)
commit_top = response.commit
assert commit_top is not None
assert commit_top.subject == b"in topic"
......@@ -74,11 +69,9 @@
response = grpc_stub.FindCommit(request)
commit_top = response.commit
assert commit_top is not None
assert commit_top.subject == b"in topic"
request = FindCommitRequest(
repository=Repository(relative_path='repo1'),
revision=b'unknown')
request = FindCommitRequest(repository=grpc_repo, revision=b'unknown')
response = grpc_stub.FindCommit(request)
assert not response.HasField('commit')
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment