Skip to content
Snippets Groups Projects
Commit eb5ffde1 authored by Georges Racinet's avatar Georges Racinet
Browse files

CommitService.TreeEntry: fix discrepancy with Gitaly

We had a Gitaly Comparison test, but it was actually comparing
HGitaly with itself (!), see the change in `assert_compare_tree_entry()`.

Then of course, whether it was initially correct or not,
we had discrepancies to fix:

- a gRPC `NOT_FOUND` is expected for unknown paths and revisions
- `.` is not a valid path *for this method*
- chunking in Gitaly happens in chunks of 16 kiB, but it's not
  consistent: sometimes the last chunk can be up to 16 kiB + 1023B
  long, sometimes, we get exact chunks. It's not clear in Gitaly
  code base exactly what happens: added logs in `streamio.go` showed
  us that this is what gets passed to it (not recut, then, since
  it's meant to cut at 128kiB).
  For these reasons, we gave up on comparing chunk by chunk and
  test the metadata only.
parent 11825d33
No related branches found
No related tags found
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment