RefService.FindLocalBranches: fixing discrepancies with Gitaly
The expected response was actually in full ref form (as `refs/heads`). It is probable that the Rails app is resilient with respect to that. Gitaly response is sorted (bad for perf, but nothing obvious we can do, GitLab 14.2 will even introduce different sorting criteria). This RPC method was implemented before we had Gitaly Comparison tests, this underlines once more how crucial they are.
parent
ef460712
No related branches found
No related tags found
Showing
- hgitaly/branch.py 12 additions, 0 deletionshgitaly/branch.py
- hgitaly/service/ref.py 2 additions, 1 deletionhgitaly/service/ref.py
- hgitaly/service/tests/test_ref.py 1 addition, 1 deletionhgitaly/service/tests/test_ref.py
- tests_with_gitaly/test_ref.py 37 additions, 0 deletionstests_with_gitaly/test_ref.py
Loading
Please register or sign in to comment