- Mar 25, 2021
-
-
Sushil Khanchi authored
-
Sushil Khanchi authored
-
- Mar 23, 2021
-
-
Sushil Khanchi authored
-
- May 25, 2021
-
-
Georges Racinet authored
This demonstrates how to use `message.Logging`. It is still quite partial, but we can generalize later, and make logging of incoming requests more systematic.
-
- Apr 04, 2021
-
-
Georges Racinet authored
With gRPC, the `repr` of messages, notably Gitaly Requests is made of multiple lines. This is very bad for logging: a log should always be made of a single line for: - meaningful grepping - detangling when several processes log to the same file We want in particular service method to be able to log easily their incoming requests and/or more messages, but we want the formatting to be done only if the log is actually to be emitted (important to avoid debug logs to make production servers choke). This is usually achieved with the following pattern, because logging evaluation is inherently lazy. ```python logging.debug('the interesting object is %r', obj) ``` We could use extras, as `hg-loggingmod` does for the repository, but that is evaluated in the final formatting of the entire log line, and requires to register a specific format, then a specific handler to use it. The provided solution (wrapping in a class), is not zero-cost, but is expected to be cheap enough for the time being.
-
- May 18, 2021
-
-
Georges Racinet authored
This goes with the general preparation for Heptapod 0.22 and comes with interesting diff options.
-
- Apr 25, 2021
-
-
Georges Racinet authored
Now that everything is back to normal, it is mandatory again.
-
Georges Racinet authored
This was covered by Gitaly comparison tests, but not by direct tests. The resulting CI failure was masked by the temporary incompatibility of hg-evolve stable with Mercurial stable due to the latter being bumped to 5.8rc
-
- Apr 22, 2021
-
-
Georges Racinet authored
-
Georges Racinet authored
-
Georges Racinet authored
-
Georges Racinet authored
-
Georges Racinet authored
-
Georges Racinet authored
Nothing of consequence to us: - more comments - removal of `name` field for Git remotes (mirrors-related) operations
-
- Apr 11, 2021
-
-
Sushil Khanchi authored
-
Sushil Khanchi authored
There was a case, found while writing gitaly comparison test for FindCommits (next patch) where current DAG logic missed some cset to include. r1...r2 revspec means, csets ancestor of r1 or r2, but not ancestor of both. Graph: D | \ B C | | | / A | O revspec: 'D...B' Expected revs: (D, C) Logic before this patch would return: (D,)
-
Sushil Khanchi authored
-
Sushil Khanchi authored
The change around offset make sure that we follow along with Gitaly and give priority to offset first, then limit. If no limit is passed, then request.limit is Zero.
-
Sushil Khanchi authored
-
- Apr 21, 2021
-
-
Georges Racinet authored
The reason why Gitaly does not respect `WRITE_BUFFER_SIZE` even though the Blob serving method go through its `streamio.SendWriter` object which enforces it is now roughly understood: the `SendWriter` object is called for the smaller chunks generated by `io.CopyN`. Since this does not look to be the actual intent in Gitaly and may be corrected later, we make HGitaly abide to `WRITE_BUFFER_SIZE` right away. This makes our code more consistent. Also, this makes the default chunk size go up from 16kB to 128kB. It wouldn't be very surprising if the penalty for chunks that are too small (number of requests multiplied by 8) would be bigger in a Python program than in a Go program, because we may have a higher overhead per request.
-
Georges Racinet authored
This fixes a flakiness in the comparison tests for `get_blob` and `get_blobs`: Gitaly's chunking is not constant, seems to depend on the (circumstantial) size of some inner buffers or similar. Hence a direct comparison of Gitaly and HGitaly responses is flay. Instead, we are focusing on what matters: repetition of metadata like oid and size (or not) and of course that the whole content is correct.
-
- Apr 22, 2021
-
-
Georges Racinet authored
(merged from stable branch)
-
Georges Racinet authored
It seems that the current stable branch of hg-evolve is not ready for the current stable branch of Mercurial (5.8rc)
-
- Apr 15, 2021
-
-
Georges Racinet authored
-
Georges Racinet authored
-
Georges Racinet authored
-
Georges Racinet authored
-
Georges Racinet authored
-
Georges Racinet authored
The forking that the `hgitaly-serve` command is doing by default is harmful when we want to debug with pdb: request handling always end in an error. The new `--mono-process` option solves that by serving directly from the main process. This is probably a matter of forwarding all the right file descriptors for the tty, but it's not worth the investigation time when there is such a simple solution. Could have done it in the command itself, but this is probably easier to maintain in the `server` module and certainly easier to test. No strong assertions that it doesn't fork in the test, but coverage proves that the early return got executed; that should be enough.
-
Georges Racinet authored
Previous fixes have been developed and measured in a Python 3.9 virtualenv (HDK). Replaying the measurements in a Python 3.8 HDK (the only supported Python version in all current Heptapod branches) immediately showed that this wasn't enough. After reconstruction of the virtualenv with Python 3.8, it became obvious that repository instances (and classes) where doubled, and the reason was the systematic instantiation of a sharedrepo source. Applying the same treatment for the latter got us back to the improvement previously obtained. It seems frankly dubious that the Python version is really implicated, but it could happen: we're after all dealing with stuff that the GC didn't clear by itself. Still, it could simply have been a matter of library version (not Mercurial, it's the same one).
-
Georges Racinet authored
For something similar with hgweb, look at changeset ff2370a70fe8 in Mercurial. Surprisingly, this does not change the memory footprint in our current investigations (which is just using examples/client.py with more calls). This means that the regular garbage collector was able to reap benefits of the parent changeset (calling `gc.collect()` is supposed to be more aggressive on the oldest generation). Still, keeping this as a safety net because our example certainly wouldn't cover all possible situations With rates of 100 and 500, the new log lines show us the GC working, with more to collect at 500 than at 100. But at 1000, we get back to the same amounts of collected objects and time spent than with 100. This suggests that this is close to the natural rate, hence we aren't really harming performance. In any case, this is a constant, and we could make it more configurable if needed.
-
Georges Racinet authored
This brings down the leaking over 1000 requests from 55MB to about 5MB. We are not yet forcing garbage collection (as `hgwebdir` does). The `_filteredrepotypes` keeps a correspondence between unfiltered repository classes and the filtered version. The problem is that each new repository is an instance of the single-usage class generated in `hgext3rd.topic.reposetup`, so these accumulate in `_filteredrepotypes`. Ironically the mapping seems to be there to avoid some other case of leaking: ``` # Python <3.4 easily leaks types via __mro__. See # https://bugs.python.org/issue17950. We cache dynamically created types # so they won't be leaked on every invocation of repo.filtered(). _filteredrepotypes = weakref.WeakKeyDictionary() ``` One could imagine that garbage collection of the repo would also just clear its reference from the `WeakKeyDictionary`, but it doesn't happen. A final suprise is that this unlocks the collection of `ui` instances. According to investigation made with `guppy3` the class objects were actually the ones eating the most memory, but getting rid of `ui` instances is also good news.
-
Georges Racinet authored
Found out while investigating heptapod#466 that actually the machinery behind `hg.repository` actually performs a copy on its own. Our copy was adding pressure on the Python memory system. This does not cure the memory leak, but it saves about 2MB of leak over 1000 requests, even though it doesn't change the fact that none of these ui instances are actually collected (seen through instrumentation not part of this changeset). From `localrepo.py` in Mercurial 5.6.1: ``` def makelocalrepository(baseui, path, intents=None): """Long docstring not cited here.""" ui = baseui.copy() # Prevent copying repo configuration. ui.copy = baseui.copy (...) ``` Note that this last line actually prevents `baseui` ( would be the copy we were creating) to be freed immediately. makelocalrepository in turn is called via this backtrace: ``` venv/lib64/python3.9/site-packages/mercurial/hg.py(221)repository() -> peer = _peerorrepo( venv/lib64/python3.9/site-packages/mercurial/hg.py(188)_peerorrepo() -> obj = _peerlookup(path).instance( venv/lib64/python3.9/site-packages/mercurial/localrepo.py(3214)instance() -> return makelocalrepository(ui, localpath, intents=intents) > venv/lib64/python3.9/site-packages/mercurial/localrepo.py(517)makelocalrepository() -> ui = baseui.copy() ```
-
Georges Racinet authored
This will make instrumentation for memory investigation easier.
-
Georges Racinet authored
Blob and Tree related service methods Closes #16, #43, and #44 See merge request !57
-