- Nov 15, 2021
-
-
Georges Racinet authored
-
Georges Racinet authored
-
Georges Racinet authored
On my laptop, this is enough to make the tests pass. Not to pretend this is satisfactory.
-
- Nov 14, 2021
-
-
Georges Racinet authored
- `FindRefName` has been removed from protocol (probably a good thing as it was a fuzzy heuristic anyway) - `SetFullPath` now returns a proper `NotFound` error if repository does not exist. - `FindRefName` was the only caller of `ensure_gitlab_branches_state_file`, hence we needed a new test to maintain coverage.
-
Georges Racinet authored
-
Georges Racinet authored
The test location was chosen in anticipation of a future move of diff helper classes and functions to the `hgitaly.diff`, module, as suggested in !82 (comment 165083)
-
- Oct 26, 2021
-
-
Sushil Khanchi authored
-
- Oct 17, 2021
-
-
Sushil Khanchi authored
-
- Nov 11, 2021
-
-
Georges Racinet authored
-
- Oct 25, 2021
-
-
Georges Racinet authored
The new RpcHelper was developed against with the stable Heptapod series, in which we have hg-git 0.9.x, but the GitHandler is not available at package top level in 0.10.x. This new spelling of the import works for both. (grafted from 298bc407658e)
-
- Nov 10, 2021
-
-
Georges Racinet authored
See heptapod#573
-
- Nov 05, 2021
-
-
Georges Racinet authored
-
- Nov 03, 2021
-
-
Georges Racinet authored
-
Georges Racinet authored
-
Georges Racinet authored
-
Georges Racinet authored
-
Georges Racinet authored
-
Georges Racinet authored
This hadn't been done with the other tasks of heptapod#542 (perhaps just not pushed or an unnoticed failed push). Since Heptapod 0.25.1 uses the same 0.16.0 as Heptapod 0.25.0 (was still the default series when it was cut), this had no practical consequences, but we need it for the 0.25.2 release.
-
Georges Racinet authored
This was a long standing TODO, and it finally had bad consequences, such as heptapod#554, because the Rails app introduced an early return if body size is 0 in upstream 13.3.0 (see heptapod@b937e23d5321). In turn, to test this in comparison with Gitaly, we have to make the ironing of differences that should not matter a bit smarter. The trailing line ending thing should be settled at some point, though.
-
- Oct 29, 2021
-
-
Sushil Khanchi authored
-
- Oct 25, 2021
-
-
Georges Racinet authored
The new RpcHelper was developed against with the stable Heptapod series, in which we have hg-git 0.9.x, but the GitHandler is not available at package top level in 0.10.x. This new spelling of the import works for both.
-
Georges Racinet authored
-
Georges Racinet authored
-
Georges Racinet authored
-
- Oct 24, 2021
-
-
Georges Racinet authored
Now it compares the entire streams of responses and not just lists of commit ids. That being said, it's easy to make a test irrelevant with a bug that would have both Mercurial and Git return empty responses. Had to shoehorn somewhat the switch to sorting mode and back, using a custom attribute on `rpc_helper`, but that still works. Additional remarks: - if a changeset user is `testuser`, then Git puts `none@none` for the email address. - some assertions are now self-explanatory, we need less comments
-
Georges Racinet authored
It is now able to handle `..` and `...` ranges. Also, an incoming non-sha revision is now returned untouched: this will be useful for arguments that can be either symbolic (e.g., refs) and direct SHAs.
-
Georges Racinet authored
Discrepancy with Git found While refactoring the Gitaly Comparison tests for this method. It is possible that the `chunked` helper itself should do it systematically. We'll see.
-
Georges Racinet authored
This one is very direct.
-
Georges Racinet authored
The `rpc_helper` argument should be often useful, the `vcs` can be in some cases.
-
Georges Racinet authored
It probably doesn't change much in execution time, but it's clearer anyway.
-
Georges Racinet authored
With `rpc_helper.assert_compare`, it is no longer useful and has become a distraction to the reader.
-
Georges Racinet authored
This one demonstrates the case where one needs the `RpcHelper` instance in the normalizer, hence a chicken-and-egg problem that Python closure rules don't have a problem with. Still it would be better to introduce a `rpc_helper` argument to the normalizer. Also cheating a bit, relying on the fact that `hg2git(git_sha)` will always return `git_sha`. It would be better to introduce a `vcs` kwarg to normalizers. Both changes require changing all existing normalizers, so it be better be done in a follow-up.
-
- Oct 21, 2021
-
-
Georges Racinet authored
The upcoming conflict didn't happen, but that is probably because we forgot to add new comparison tests with pagination and sort. It will be probably easier with those new helpers
-
Georges Racinet authored
It is rather clear that these normalizations will be systematically needed. We could have introduced something similar to the `response_sha_attrs` argument of `RpcHelper()`, but it would have been a bit complicated to implement right now, as it would have to share some of the iteration logic with `message_to_git()`. Could be a subject for a subsequent refactoring, if we don't decide to tackle the differences before (but that requires HGitaly1 to be a thing of the past).
-
Georges Racinet authored
-
Georges Racinet authored
This is a just-released feature of mercurial-testhelpers. With the inner functions enclosing the `hg_repo` local variable we had to systematically redefine `hg_repo` upon each reload() or stop using that abbreviation. We chose the latter.
-
Georges Racinet authored
-