RepositoryService.FetchBundle: initial implementation
- May 10, 2022
-
-
Georges Racinet authored
The main difference at this point with `CreateRepositoryFromBundle` is that `FetchBundle` accepts existing repositories (it is meant for incremental restorations).
-
- May 11, 2022
-
-
Georges Racinet authored
Using immediately in an existing backup/restore test to keep coverage. There is a certain amount of duplication between the `ServiceFixture` class and the `tests.common` helper module. We should probably merge them together at some point.
-
Georges Racinet authored
Will be useful for the forthcoming new tests.
-
Georges Racinet authored
Will be reused in more tests to come.
-
- May 10, 2022
-
-
Georges Racinet authored
In case of error after repository creation, Gitaly makes sure to remove the created repo. We must do the same, and it opens up room for retries.
-
Georges Racinet authored
-
Georges Racinet authored
This should also be applicable in other methods.
-
Georges Racinet authored
The only use case of `repo_path_for_creation()` was to feed `hg_init_repository()`. It is simpler for callers not to have to.
-
Georges Racinet authored
-
Georges Racinet authored
We will soon switch `hg_init_repository` to exception raising. This takes care of the new `try` statement and the related indentation.
-
Georges Racinet authored
The existing functions such as `not_found()` are useful for a quick and early return, but they are impractical for mutualization or chaining (this is not Rust, we have neither the `Result<T, E>` type nor the `?` operator for easy propagation).
-
Georges Racinet authored
Extracting this from `RepositoryService` will help avoid duplication in forthcoming methods. Also, as usual, implementation details such as compatibility with unpython3inic constraints of Mercurial core do not belong to the service method itself.
-