Skip to content
Snippets Groups Projects

FindCommits: add support for all filtering options

Closed Sushil Khanchi requested to merge topic/default/find-commits into branch/default

Except disable_walk because it will be removed from Gitaly (as per a comment I found) so I guess we can exclude this option.

Merge request reports

Pipeline #13861 passed

Pipeline passed for 4895c54d on topic/default/find-commits

Test coverage 100.00% (0.00%) from 3 jobs
Approval is optional

Closed by Sushil KhanchiSushil Khanchi 4 years ago (Dec 5, 2020 12:51pm UTC)

Merge details

  • The changes were not merged into branch/default.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Author Maintainer

    @gracinet well, there is one last filtering "option" I somehow missed i.e. order. The good thing is it can also be achieved using logcmdutil.

    Edited by Sushil Khanchi
  • Hi, I suppose the closing is due to the change of source branch.

    For the record, you don't need to open an new MR after that: you can simply reopen and edit the existing one. Upstream GitLab doesn't allow to change the source branch, but Heptapod now does.

  • Anyway, since let's finish this on !21 (merged), now that it's also there.

  • Author Maintainer

    Oh, I didn't notice that it got closed automatically (I know it was obvious, after branch change). I was planning to close this with a comment.

    For the record, you don't need to open a new MR after that: you can simply reopen and edit the existing one. Upstream GitLab doesn't allow to change the source branch, but Heptapod now does.

    That's really cool :100: I created a new MR from the fact I knew (from Gitlab) it's not allowed to change source.

Please register or sign in to reply
Loading