Skip to content
Snippets Groups Projects

DiffService.GetPatchID and install/config doc

Merged Georges Racinet requested to merge topic/stable/get-patch-id into branch/stable
  1. Feb 12, 2024
  2. Feb 06, 2024
    • Georges Racinet's avatar
      DiffService.GetPatchId: initial implementation · 972fd9a8b2cc
      Georges Racinet authored
      Since `git patch-id` does not involve the repository at all (it
      ingests a patch and outputs a hash), we are actually spawning it,
      with a Mercurial generated patch.
      
      For general consistency (and hoping it does not matter so much),
      we are computing the index lines as for the `RawDiff` method, but
      Git seems to actually ignore it.
      
      We are avoiding to extract the full content of binary files, as it
      would be expensive and essentially useless. This is also what Gitaly
      does, and we probably should generalize it to some other `DiffService`
      methods (to be checked)
      
      As the Comparison Tests display, the patch id computed by HGitaly
      turns out to be identical to the done by Gitaly for simple text-only
      diffs. That will obviously not be true of binary diffs.
      972fd9a8b2cc
  3. Feb 11, 2024
Loading