Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
hgitaly
Manage
Activity
Members
Labels
Plan
Issues
53
Issue boards
Milestones
Code
Merge requests
1
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Model registry
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
heptapod
hgitaly
Merge requests
!238
Fixed comparison tests to match errors in Gitaly 16.8
Code
Review changes
Check out branch
Download
Patches
Plain diff
Merged
Fixed comparison tests to match errors in Gitaly 16.8
topic/default/gitlab-16.8
into
branch/default
Overview
0
Commits
1
Pipelines
1
Changes
2
Merged
Georges Racinet
requested to merge
topic/default/gitlab-16.8
into
branch/default
10 months ago
Overview
0
Commits
1
Pipelines
1
Changes
2
Expand
🚀
👍
0
👎
0
Merge request reports
Compare
branch/default
branch/default (base)
and
latest version
latest version
2abe60aa
1 commit,
10 months ago
2 files
+
15
−
10
Inline
Compare changes
Side-by-side
Inline
Show whitespace changes
Show one file at a time
Files
2
Search (e.g. *.vue) (Ctrl+P)
tests_with_gitaly/test_commit.py
+
8
−
1
Options
@@ -132,7 +132,14 @@
# case when revision does not exist
for
path
in
(
b
''
,
b
'
foo
'
):
assert_compare_errors
(
revision
=
b
'
be0123ef
'
*
5
,
path
=
path
)
# as of Gitaly 16.8, the Gitaly details are
# 'panic: runtime error: invalid memory address or \
# nil pointer dereference'
# (used to be exit code 128, clearly rewritten from subprocess
# into native Golang. However it would be over-ridiculous to
# mimic that one.
assert_compare_errors
(
revision
=
b
'
be0123ef
'
*
5
,
path
=
path
,
same_details
=
False
)
# case when file does not exist or does not match
assert_compare
(
revision
=
b
'
branch/default
'
,
path
=
b
'
no-such-file
'
)
Loading