Skip to content
Snippets Groups Projects

RHGitaly ListCommitsByRefName

  1. May 18, 2024
    • Georges Racinet's avatar
      RHGitaly ListCommitsByRefName · cb16826e1c8d
      Georges Racinet authored
      The implementation is straightforward because we are currently in a hurry.
      
      It is obviously suboptimal performance-wise as the state files will be reopened
      and scanned  for each GitLab ref. This is what makes it so easy, as the
      `gitlab_revision_node_prefix` function doing all the work. A variant of the
      latter for several refs should be used to improve on that, hoping it would
      be useful elsewhere.
      
      On the other hand, this gRPC method is most frequently called on a single ref,
      so this should not matter much and still be orders of magnitude faster than
      the Python version, with the usual guarantees to succeed thanks to the async
      nature of `tonic`.
      cb16826e1c8d
    • Georges Racinet's avatar
      ListCommitsByRefName Comparison tests · 16f81804e56c
      Georges Racinet authored
      They were missing! Probably one of our earliest methods.
      
      Also adding a helper for keep-arounds normalization on the `RpcHelper` class.
      16f81804e56c
    • Georges Racinet's avatar
      gitlab_ref: added `parse_keep_around_ref_path` method · a625d0bf6532
      Georges Racinet authored
      It will be useful in various tests.
      a625d0bf6532
Loading