Skip to content
Snippets Groups Projects
  1. Jul 15, 2024
  2. Jul 11, 2024
  3. Jul 15, 2024
  4. Jul 12, 2024
  5. Jun 30, 2024
  6. Apr 15, 2024
  7. Jul 12, 2024
  8. Jul 10, 2024
  9. Apr 08, 2024
  10. Jun 26, 2024
    • Stan Hu's avatar
      Attempt to retry twice to determine Redis server version · 91afd5f5b826
      Stan Hu authored
      We had two different customers upgrade GitLab and run into `stderr:
      Error: Connection reset by peer` when attempting to determine the
      Redis version. This appears to have occurred because `gitlab-ctl
      reconfigure` can restart Redis right before it checks the version.
      This causes the `gitlab-ctl reconfigure` to fail outright.
      
      To avoid this failure mode, set the Chef `retries` parameter to 2. By
      default the `retry_delay` is 2 seconds.
      
      Relates to
      https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/8597
      
      Changelog: fixed
      91afd5f5b826
  11. Jun 27, 2024
    • Stan Hu's avatar
      Fix Redis password handling with reserved characters · ba009e3bf187
      Stan Hu authored
      Previously including reserved characters such as `@` in the Redis
      password would fail because `URI::Generic::DEFAULT_PARSER.escape` did
      not consider `@` unsafe, which it generally isn't per RFC 2396 and
      3986. However, the `@` is not allowed in the userinfo field, and the
      URI builder for Ruby fails if using a reserved character were
      included.
      
      To fix this, use `ERB.url_encode`, which always escapes any
      non-alphanumeric string.
      
      Relates to https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/8602
      
      Changelog: fixed
      ba009e3bf187
  12. Jun 04, 2024
  13. Jun 24, 2024
  14. Jun 12, 2024
    • Vasilii Iakliushin's avatar
      Disable request buffering for new SSH endpoints · ed3f9dbbf52b
      Vasilii Iakliushin authored
      Contributes to https://gitlab.com/gitlab-org/gitlab/-/issues/466160
      
      **Problem**
      
      While testing the new implementation of SSH endpoints for git related
      actions. I noticed a problem reproducible in my
      local environment.
      
      The request from GitLab-Shell to Workhorse was hanging. After in
      investigation I discovered the root cause of this problem.
      
      In our NGINX configuration we use request buffering. After adding the
      new endpoint to the list of exceptions, then problem was resolved.
      
      **Solution**
      
      Add new endpoints to the list of exceptions for nginx configuration.
      
      Changelog: changed
      ed3f9dbbf52b
  15. Jun 24, 2024
    • Ian Baum's avatar
      Add gitlab-backup user · ab269a7991a2
      Ian Baum authored
      * Creates the gitlab-backup user and groups if they dont' exist
      * Adds the user to other groups
      * For use by gitlab-backup-cli for read/write permission to data for
        backups and restores
      
      Changelog: added
      ab269a7991a2
  16. Jun 19, 2024
  17. Jun 13, 2024
  18. Jun 11, 2024
  19. Jun 07, 2024
  20. Jun 04, 2024
  21. May 22, 2024
  22. Apr 18, 2024
  23. Apr 17, 2024
  24. May 29, 2024
  25. May 21, 2024
    • Stan Hu's avatar
      redis: Fix handling of passwords with a space · 191ff5a0879a
      Stan Hu authored
      Previously we used `CGI.escape(password)`, but this escapes spaces as
      `+` instead of `%20`. However, RFC 3986 says the password should be
      percent-encoded. In fact, while the Ruby Redis client appears to
      connect fine with the `+`, the Go client doesn't work with that.
      Update the helper to encode passwords according to RFC 3986.
      
      Changelog: fixed
      191ff5a0879a
  26. May 16, 2024
  27. May 15, 2024
  28. May 22, 2024
  29. May 17, 2024
  30. May 10, 2024
  31. Apr 26, 2024
  32. May 09, 2024
  33. May 07, 2024
Loading