- Jul 12, 2024
-
-
Robert Marshall authored
Add support for configuring Redis client timeouts See merge request https://gitlab.com/gitlab-org/omnibus-gitlab/-/merge_requests/7749 Merged-by:
Robert Marshall <rmarshall@gitlab.com> Approved-by:
Alec Xu <axu@gitlab.com> Approved-by:
Robert Marshall <rmarshall@gitlab.com> Reviewed-by:
Robert Marshall <rmarshall@gitlab.com> Co-authored-by:
Stan Hu <stanhu@gmail.com>
-
- Jun 30, 2024
-
-
Stan Hu authored
For some installations, the default 1-second Redis connect timeout may not be sufficient. Just as PostgreSQL has the ability to configure the connection timeout, add the same for Redis. Include read and write timeout options for completness. Relates to https://gitlab.com/gitlab-org/gitlab/-/issues/466271 Changelog: added
-
- Apr 15, 2024
-
-
Balasankar 'Balu' C authored
All the usecases of old RedisHelper has been migrated to NewRedisHelper. Drop the old RedisHelper and rename NewRedisHelper to replace it. Signed-off-by:
Balasankar 'Balu' C <balasankar@gitlab.com>
-
- Jul 12, 2024
-
-
Ash McKenzie authored
Adds configuration support for Pure-SSH LFS protocol via the `gitlab_shell['lfs_pure_ssh_protocol']` option. Closes https://gitlab.com/gitlab-org/gitlab-shell/-/issues/773 Changelog: added
-
- Jul 10, 2024
-
-
Naman Jagdish Gala authored
- Migrates domain redirect and resolution logic for Pages into the Pages binary from the nginx configuration file template. Related: https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/8581+ Changelog: added
-
- Apr 08, 2024
-
-
Balasankar 'Balu' C authored
Drop the uses of old RedisHelper class to move everything to the NewRedisHelper logic Signed-off-by:
Balasankar 'Balu' C <balasankar@gitlab.com>
-
Balasankar 'Balu' C authored
Certain methods in the Redis Helper are to be used in libraries also, where the node object is unavailable. In those scenarios, the methods have to work with the Gitlab object. Make those methods class methods that take a config hash as argument. Also create instance methods with same name, which call these class methods and pass the node object as argument. Signed-off-by:
Balasankar 'Balu' C <balasankar@gitlab.com>
-
- Jun 26, 2024
-
-
Stan Hu authored
We had two different customers upgrade GitLab and run into `stderr: Error: Connection reset by peer` when attempting to determine the Redis version. This appears to have occurred because `gitlab-ctl reconfigure` can restart Redis right before it checks the version. This causes the `gitlab-ctl reconfigure` to fail outright. To avoid this failure mode, set the Chef `retries` parameter to 2. By default the `retry_delay` is 2 seconds. Relates to https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/8597 Changelog: fixed
-
- Jun 27, 2024
-
-
Stan Hu authored
Previously including reserved characters such as `@` in the Redis password would fail because `URI::Generic::DEFAULT_PARSER.escape` did not consider `@` unsafe, which it generally isn't per RFC 2396 and 3986. However, the `@` is not allowed in the userinfo field, and the URI builder for Ruby fails if using a reserved character were included. To fix this, use `ERB.url_encode`, which always escapes any non-alphanumeric string. Relates to https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/8602 Changelog: fixed
-
- Jun 04, 2024
-
-
Will Chandler authored
57396c7ab (Prevent Gitaly storages from using the same path, 2024-05-09) added a check to validate that only one storage is associated with a given filesystem path. We have received a customer report[0] that the error message used is confusing. Update the message to make it clear what the problem is. [0] https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/8565
-
- Jun 24, 2024
-
-
Balasankar 'Balu' C authored
Disable request buffering for new SSH endpoints See merge request https://gitlab.com/gitlab-org/omnibus-gitlab/-/merge_requests/7713 Merged-by:
Balasankar 'Balu' C <balasankar@gitlab.com> Approved-by:
Balasankar 'Balu' C <balasankar@gitlab.com> Co-authored-by:
Vasilii Iakliushin <viakliushin@gitlab.com>
-
- Jun 12, 2024
-
-
Vasilii Iakliushin authored
Contributes to https://gitlab.com/gitlab-org/gitlab/-/issues/466160 **Problem** While testing the new implementation of SSH endpoints for git related actions. I noticed a problem reproducible in my local environment. The request from GitLab-Shell to Workhorse was hanging. After in investigation I discovered the root cause of this problem. In our NGINX configuration we use request buffering. After adding the new endpoint to the list of exceptions, then problem was resolved. **Solution** Add new endpoints to the list of exceptions for nginx configuration. Changelog: changed
-
- Jun 24, 2024
-
-
Ian Baum authored
* Creates the gitlab-backup user and groups if they dont' exist * Adds the user to other groups * For use by gitlab-backup-cli for read/write permission to data for backups and restores Changelog: added
-
- Jun 19, 2024
-
-
Balasankar 'Balu' C authored
Add public_key_algorithms option for gitlab-sshd Closes #8482 See merge request https://gitlab.com/gitlab-org/omnibus-gitlab/-/merge_requests/7660 Merged-by:
Balasankar 'Balu' C <balasankar@gitlab.com> Approved-by:
Clemens Beck <cbeck@gitlab.com> Approved-by:
Balasankar 'Balu' C <balasankar@gitlab.com> Reviewed-by:
Roger Meier <r.meier@siemens.com> Reviewed-by:
Clemens Beck <cbeck@gitlab.com> Co-authored-by:
Roger Meier <r.meier@siemens.com>
-
Roger Meier authored
This MR adds the option to explicitly set the public key algorithms as introduced via https://gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/986 Closes https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/8482 Changelog: added
-
- Jun 13, 2024
-
-
Roger Meier authored
Issue: https://gitlab.com/gitlab-org/gitlab/-/issues/444193 MR: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/153877 Changelog: added
-
Clemens Beck authored
* Update consul version shipping with Omnibus. * Update supported BYO consul version. * Fix minor bug in BYO consul helper script. Changelog: changed
-
Naman Jagdish Gala authored
Related: https://gitlab.com/gitlab-org/gitlab/-/issues/462344 Changelog: fixed
-
- Jun 11, 2024
-
-
Balasankar 'Balu' C authored
Allows the ActionCable configuration to receive its redis configuration from an external command. Changelog: added Signed-off-by:
Balasankar 'Balu' C <balasankar@gitlab.com>
-
- Jun 07, 2024
-
-
Naman Jagdish Gala authored
Related: https://gitlab.com/gitlab-org/gitlab-pages/-/issues/548+ Changelog: added
-
- Jun 04, 2024
-
-
Clemens Beck authored
The flag postgres_exporter['per_table_stats'] was replaced in favor of postgres_exporter['flags']['collector.stat_user_tables']. Deprecation documentation: https://docs.gitlab.com/ee/update/deprecations.html#postgres_exporterper_table_stats-configuration-setting Changelog: removed Closes https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/8169
-
- May 22, 2024
-
-
Balasankar 'Balu' C authored
Changelog: added Signed-off-by:
Balasankar 'Balu' C <balasankar@gitlab.com>
-
- Apr 18, 2024
-
-
Jaime Martinez authored
Changelog: deprecated
-
- Apr 17, 2024
-
-
Jaime Martinez authored
Changelog: added
-
- May 29, 2024
-
-
Balasankar 'Balu' C authored
Add ability to prefix session cookies See merge request https://gitlab.com/gitlab-org/omnibus-gitlab/-/merge_requests/7605 Merged-by:
Balasankar 'Balu' C <balasankar@gitlab.com> Approved-by:
Bojan Marjanovic <bmarjanovic@gitlab.com> Approved-by:
Balasankar 'Balu' C <balasankar@gitlab.com> Reviewed-by:
Omar Qunsul <oqunsul@gitlab.com> Reviewed-by:
Bojan Marjanovic <bmarjanovic@gitlab.com> Co-authored-by:
Omar Qunsul <oqunsul@gitlab.com>
-
Omar Qunsul authored
Addressing: https://gitlab.com/gitlab-org/gitlab/-/issues/439945 Changelog: added
-
- May 21, 2024
-
-
Stan Hu authored
Previously we used `CGI.escape(password)`, but this escapes spaces as `+` instead of `%20`. However, RFC 3986 says the password should be percent-encoded. In fact, while the Ruby Redis client appears to connect fine with the `+`, the Go client doesn't work with that. Update the helper to encode passwords according to RFC 3986. Changelog: fixed
-
- May 16, 2024
-
-
Balasankar 'Balu' C authored
- Ensure legacy redis sentinel master configuration for rails gets parsed and loaded into resque with the new redis helper. Closes https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/8540 Signed-off-by:
Balasankar 'Balu' C <balasankar@gitlab.com>
-
- May 15, 2024
-
-
Balasankar 'Balu' C authored
- Moves the Gitlab Rails library to use the new redis helper logic code path. Signed-off-by:
Balasankar 'Balu' C <balasankar@gitlab.com>
-
Stan Hu authored
Previously slow logs were disabled by default, but this makes it difficult to troubleshoot performance issues. Set the default value to 1 second, as we do on GitLab.com and on Dedicated. Changelog: changed
-
- May 22, 2024
-
-
Naman Jagdish Gala authored
- Adds cases to the proxy_redirect statements to account for when the administrator configured a custom listen_port for the GitLab Pages service. Related: https://gitlab.com/gitlab-org/gitlab/-/issues/458587 Changelog: fixed
-
- May 17, 2024
-
-
Robert Marshall authored
- Grafana was removed in GitLab 16.3. This removes the deprecation messages and the attribute that was left behind to enable those messages to fire without error. Closes https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/8200 Changelog: removed
-
- May 10, 2024
-
-
Balasankar 'Balu' C authored
- If a node has legacy `git-data` storages configured but no longer runs the gitaly service, skip the unique storage path validation check. Signed-off-by:
Balasankar 'Balu' C <balasankar@gitlab.com>
-
- Apr 26, 2024
-
-
Stan Hu authored
Previously if a Redis instance listened on a UNIX socket but a password were set, GitLab Rails would not be able to authenticate. This occurred because the UNIX URL doesn't contain a password. Both Ruby and Go Redis clients support URLs in the form: unix://<user>:<password>@</path/to/redis.sock>?db=<db_number> Relates to work started in https://gitlab.com/gitlab-org/omnibus-gitlab/-/merge_requests/2194 Changelog: fixed
-
- May 09, 2024
-
-
Will Chandler authored
Gitaly is making a breaking change with v17.0 to prevent multiple storages from sharing the same local path. This is being done as part of the work to add a write-ahead log to Gitaly, see https://gitlab.com/gitlab-org/gitaly/-/issues/5598 for further details. Validate that Gitaly's config does not have more than one storage using the same path, dereferencing any symlinks. Changelog: changed
-
Balasankar 'Balu' C authored
- Adds much more detail around the process that happens when gitlab-ctl reconfigure executes. - Adds notes to the recipes to clarify what happens in the context of a reconfigure run. Signed-off-by:
Balasankar "Balu" C <balasankar@gitlab.com>
-
- May 07, 2024
-
-
Clemens Beck authored
* Remove PostgreSQL 13 builds. * Remove unused PostgreSQL 12 build definition. * Move PostgreSQL 14 from 'new' to 'default' build definition. * Update minimum PostgreSQL version notice. Closes https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/8341 Changelog: removed
-
- May 04, 2024
-
-
Gregorius Marco authored
- Eliminates code related to `min_concurrency` and `max_concurrency` options in sidekiq. Related https://gitlab.com/gitlab-com/gl-infra/scalability/-/issues/3422 Changelog: removed
-
- Apr 25, 2024
-
-
Stan Hu authored
https://gitlab.com/gitlab-org/omnibus-gitlab/-/merge_requests/7500 introduced a regression when a node with a managed Redis node has Sentinels configured in `gitlab_rails` section. Previously the `redis['default_host']` would only be set if `gitlab_rails['redis_sentinels']` were empty. Relates to https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/8465#note_1879691545 Changelog: fixed
-
- Apr 24, 2024
-
-
Gregorius Marco authored
https://gitlab.com/gitlab-com/gl-infra/scalability/-/issues/2220 Changelog: removed
-