Skip to content
Snippets Groups Projects
  1. Jan 25, 2022
  2. Jan 24, 2022
  3. Dec 01, 2021
  4. Nov 09, 2021
  5. Nov 08, 2021
  6. Nov 03, 2021
  7. Aug 06, 2021
  8. Jul 19, 2021
  9. Jan 24, 2022
  10. Jan 09, 2022
    • Fabio Huser's avatar
      Correct GitLab KAS default redis port configuration · e4741d6c015c
      Fabio Huser authored
      Using gitlab-kas with an external redis instance (`gitlab_rails['redis_host']`
      set to e.g. `my-redis`) but default port configuration (`gitlab_rails['redis_port']`
      not set) leads to an invalid redis hostname/port combination (e.g. `my-redis:`
      instead of `my-redis:6379`). This configuration works perfectly fine for other
      GitLab services (e.g. workhorse, gitlab-rails) and is also covered by unit-tests
      (see spec/libraries/redis_helper_spec.rb#59). Those services rely on the
      `redis_url` method which properly omits the default redis port completely,
      whereas gitlab-kas derives the hostname/port combination from the two values
      directly but not taking a default port value into account. This commit changes
      that behavior by adding a fall-back default redis port, in case no custom one is
      set and the tcp connection method is used.
      
      Changelog: fixed
      e4741d6c015c
  11. Jan 24, 2022
  12. Jan 21, 2022
  13. Jan 19, 2022
  14. Jan 21, 2022
  15. Jan 20, 2022
  16. Jan 21, 2022
  17. Jan 14, 2022
  18. Jan 19, 2022
  19. Jan 08, 2022
    • Fabio Huser's avatar
      Sync trailing slash usage for GitLab KAS routes · 683d846bcd3e
      Fabio Huser authored
      The GitLab Nginx templates uses the non-changeable routes `-/kubernetes-agent/`
      and `-/kubernetes-agent/k8s-proxy/` for KAS/KAS K8s API proxy forwarding.
      Both routes use trailing slashes while the GitLab rails configuration by default
      generates routes without trailing slashes. This will cause GitLab to generate a
      KAS configuration with invalid target URL, causing a connection failure as the
      server returns a HTTP 301 instead of 101. This commit syncs the temples to
      consistently using a trailing slash. Besides that, two other minor points
      were addressed:
      
      - The `gitlab_kas_external_k8s_proxy_url` example in `gitlab.rb.template`
        wrongly used the `wss://` schema but is in fact a reverse proxy for a K8s API.
        This was corrected to use `https://` instead.
      - The inline comment in `gitlab_kas.rb` used a wrong path reference. This was
        corrected as well
      
      Changelog: fixed
      683d846bcd3e
  20. Jan 18, 2022
  21. Jan 17, 2022
Loading