Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • magic-lantern magic-lantern
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 651
    • Issues 651
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 75
    • Merge requests 75
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • magic-lantern
  • magic-lanternmagic-lantern
  • Merge requests
  • !177

RequestForComments: contrib: add check-bot

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Bitbucket Importer requested to merge topic/unified/bitbucket-pr-177 into branch/unified Aug 12, 2013
  • Overview 5
  • Commits 1
  • Changes 4

Created originally on Bitbucket by frantony (Antony Pavlov)

check-bot.sh is a simple script for tracking warnings and errors during Magic Lantern build. It can be used to find the changeset that introduced a bug or a compiler warning.

check-bot.sh generates html output. You can see a sample here: http://dir.tftpd.net:7080/~ml/check-log.html

See README file for details.

check-bot does different work that build-bot does. The build-bot generated binary images and changelog mostly for an enduser. An enduser does not want to know anything about repos and changesets. An enduser want to get new features. On the contrary the developer want to find the changeset introduced the bug.

This pull request inherits some changes from the pull request:

  • https://bitbucket.org/hudson/magic-lantern/pull-request/153
  • https://bitbucket.org/hudson/magic-lantern/pull-request/165

P.S. We don't need to reinvent the wheel, there are ready-to-use tools (see http://en.wikipedia.org/wiki/List_of_tools_for_code_review). These tools has API that make possible to add necessary build scripts.

Alas in Wikipedia's List_of_tools_for_code_review page there is only one Mercurial-enabled tool: Review Board (see http://en.wikipedia.org/wiki/Review_Board).

P.P.S. The problem with current workflow is that the errors often are found AFTER applying the changeset to the main repo. The workflow could be greatly improved if the buggy changesets are refused BEFORE applying to the main repo. Please comment these sentences.

P.P.P.S. Can anybody tell me why ML use Mercurial?

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: topic/unified/bitbucket-pr-177