changegroup: don't support versions 01 and 02 with treemanifests
Since it would be terribly expensive to convert between flat manifests and treemanifests, we have decided to simply not support changegroup version 01 and 02 with treemanifests. Therefore, let's stop announcing that we support these versions on treemanifest repos. Note that this means that older clients that try to clone from a treemanifest repo will fail. What happens is that the server, after this patch, finds that there are no common versions and raises "ValueError: no common changegroup version". This results in "abort: HTTP Error 500: Internal Server Error" on the client. Before this patch, it was no better: The server would instead find that there were directory manifest nodes to put in the changegroup 01 or 02 and raise an AssertionError on changegroup.py#668 (assert not tmfnodes), which would also appear as a 500 to the client.
-
mentioned in commit 7526ed287224
-
mentioned in commit 60b5bf0fe15c
-
mentioned in commit 034671929537
-
mentioned in commit 36b585c4c22b
-
mentioned in commit f82f64ed9c8d
-
mentioned in commit d80e0110adca
-
mentioned in commit 60cd690d9df6
-
mentioned in commit 79e6a626d7ef
-
mentioned in commit 2cf264e9aa75
Please register or sign in to comment