Skip to content
Snippets Groups Projects
Commit d80e0110 authored by Matt Harbison's avatar Matt Harbison
Browse files

configitems: enable changegroup3 by default (unless using infinitepush)

The LFS extension requires this, and if it isn't enabled on the client (or the
LFS extension isn't loaded), the client gets a 500 instead of a sensible error
message.  Now it gets a different cryptic error, but maybe it can be handled
more gracefully.  c0f11347b107 indicates that treemanifest repos have this issue
too.  29cfc474c5fd mentions gating this behind `experimental` so that the format
could change, but that was 7 years ago and we now have an experimental
`changegroup4` as well.

We can keep this as a config for the next cycle in case someone runs into an
unexpected problem, and then jettison it if the infinitepush bundle name changes
are either acceptable as-is or can be handled differently.

Interestingly, there's a failed clone attempt in test-http-bad-server.t that
sometimes leaves repo data behind.  I don't recall seeing instability in this
test without changegroup3, and I don't see a pattern for when it occurs.  Since
it seems rather minor, just delete the repo unconditionally to prevent cascading
errors.
parent d27aacfd
No related branches found
No related tags found
No related merge requests found
Showing
with 150 additions and 138 deletions
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment