Skip to content
Snippets Groups Projects
  1. Jun 16, 2022
  2. Jun 14, 2022
  3. Jun 08, 2022
  4. Jun 14, 2022
  5. May 12, 2022
  6. Jun 08, 2022
  7. Jun 04, 2022
    • Manuel Jacob's avatar
      url: raise error if CONNECT request to proxy was unsuccessful · 51b07ac1991c
      Manuel Jacob authored
      The deleted code didn’t work on Python 3. On Python 2 (or Python 3 after
      adapting it), the function returned in the error case. The subsequent creation
      of SSL socket fails during handshake with a nonsense error.
      
      Instead, the user should get an error of what went wrong.
      
      I don’t see how the deleted code would be useful in the error case. The new
      code is also closer of what the standard library is doing nowadays that it has
      proxy support (which we don’t use in the moment).
      
      In the test, I use port 0 because all the HGPORTs were already taken. In
      practice, there should not be any server listening on port 0.
      51b07ac1991c
  8. Jun 03, 2022
  9. Jun 02, 2022
    • Manuel Jacob's avatar
      py3: don’t subscript socket.error · b5fe10b3c9f5
      Manuel Jacob authored
      On Python 2, socket.error was subscriptable. On Python 3, socket.error is an
      alias to OSError and is not subscriptable. The except block passes the
      exception to self.send_error(). This fails on both Python 2 (if it was
      executed) and Python 3, as it expects a string.
      
      Getting the attribute .strerror works on Python 2 and Python 3, and has the
      same effect as the previous code on Python 2.
      b5fe10b3c9f5
    • Manuel Jacob's avatar
      demandimport: eagerly load msvcrt module on PyPy · fda7ec505dc5
      Manuel Jacob authored
      fda7ec505dc5
  10. Jun 01, 2022
  11. May 21, 2022
  12. May 24, 2022
    • kiilerix's avatar
      rust: relax im-rc dependency to allow minor updates · 13c37f1c7c4b
      kiilerix authored
      This "15.0.*" requirement came from 0d99778af68a and is now replaced with plain
      "15.0".
      
      AFAICS, it really should allow (but not necessarily require) im-rc 15.1 .
      
      Narrow requirement requirements with wildcard in the version is not used in
      other places.
      13c37f1c7c4b
  13. Jun 02, 2022
  14. May 04, 2022
    • idlsoft's avatar
      narrow_widen_acl: enforce narrowacl in narrow_widen (SEC) · 6b10151b9621
      idlsoft authored
      Reviewer note: this was sent by the author as a simple bugfix, but can be
      considered a security patch, since it allows users to access things outside
      of the ACL, hence the (SEC) prefix.
      
      However, this affects the `narrow` extention which is still marked as
      experimental and has relatively few users aside from large companies with
      their own security layers on top from what we can gather.
      We feel (Alphare: or at least, I feel) like pinging the packaging list is
      enough in this case.
      6.1.3
      6b10151b9621
  15. May 30, 2022
    • Raphaël Gomès's avatar
      chg: ignore already closed fds when cleaning up · 201222849987
      Raphaël Gomès authored
      This should fix this error we see in the CI from time to time:
      
      ```
      --- /tmp/mercurial-ci/tests/test-chg.t
      +++ /tmp/mercurial-ci/tests/test-chg.t.err
      @@ -187,6 +187,26 @@
         $ chg bulkwrite --pager=on --color no --config ui.formatted=True
         paged! 'going to write massive data\n'
         killed! (?)
      +  Traceback (most recent call last):
      +    File "/tmp/hgtests._uvojvqb/install/lib/python/mercurial/commandserver.py", line 509, in _serverequest
      +      sv.cleanup()
      +    File "/tmp/hgtests._uvojvqb/install/lib/python/mercurial/chgserver.py", line 382, in cleanup
      +      self._restoreio()
      +    File "/tmp/hgtests._uvojvqb/install/lib/python/mercurial/chgserver.py", line 461, in _restoreio
      +      os.close(fd)
      +  OSError: [Errno 9] Bad file descriptor
      +  Traceback (most recent call last):
      +    File "/tmp/hgtests._uvojvqb/install/lib/python/mercurial/commandserver.py", line 693, in _acceptnewconnection
      +      self._runworker(conn)
      +    File "/tmp/hgtests._uvojvqb/install/lib/python/mercurial/commandserver.py", line 744, in _runworker
      +      prereposetups=[self._reposetup],
      +    File "/tmp/hgtests._uvojvqb/install/lib/python/mercurial/commandserver.py", line 509, in _serverequest
      +      sv.cleanup()
      +    File "/tmp/hgtests._uvojvqb/install/lib/python/mercurial/chgserver.py", line 382, in cleanup
      +      self._restoreio()
      +    File "/tmp/hgtests._uvojvqb/install/lib/python/mercurial/chgserver.py", line 461, in _restoreio
      +      os.close(fd)
      +  OSError: [Errno 9] Bad file descriptor
         [255]
      ```
      201222849987
  16. May 29, 2022
  17. May 24, 2022
  18. May 22, 2022
  19. May 17, 2022
    • Matt Harbison's avatar
      worker: adapt _blockingreader to work around a python3.8.[0-1] bug (issue6444) · 2fe4efaa59af
      Matt Harbison authored
      Python 3.8.0 is the latest I can load on Ubuntu 18.04, and I regularly hit the
      TypeError because this function is missing.  While it can be avoided by
      disabling worker usage via config option, that's a bit obscure.
      
      I'm limiting the function definition to the narrow range of affected pythons
      because there were other bugs in this area that were worked around, that I don't
      fully understand.  See the bug report for discussions on why the narrow range,
      and related commits working around other bugs.
      
      Differential Revision: https://phab.mercurial-scm.org/D12627
      2fe4efaa59af
  20. May 04, 2022
  21. May 19, 2022
  22. May 17, 2022
  23. May 16, 2022
    • Pierre-Yves David's avatar
      ci: do not trigger phabricator for merge-request · 477b5145e1a0
      Pierre-Yves David authored
      The fast the phabricator steps has a `rules` entry makes it selected for the
      special `merge_requests` pipelines. The other ones behave as default and are not
      selected tot the mrege_request pipelines.
      
      This result in a second pipeline to be created, with only the phabricator
      pipeline in it. Which usually succeed fast (since there is nothing to do).
      
      This is harmful as this create a false sense of "the series is passing" and
      Gitlab will use this simplistic pipeline for validation.
      
      By explicitly preventing the pipeline to be created in the merge-request case,
      we prevent this situation to happens
      
      Note that the job will be dropped (alonside phabricator) in the next two weeks
      anyway.
      477b5145e1a0
  24. May 12, 2022
    • Kyle Lippincott's avatar
      amend: stop specifying matcher, get all copies in wctx · df68d64b0d50
      Kyle Lippincott authored
      When we're recreating the commit that we'll be committing, we don't want to
      filter our copy information based on just the *new* [versions of the] files
      we're amending. The test has an example of this case, but for clarity, the
      situation is:
      
      ```
      $ hg cp src dst && hg commit
      <do some work>
      $ hg amend some_unrelated_file.txt
      $ hg status --copies
      A dst
      A some_unrelated_file.txt
      ```
      
      What *should* happen is that `dst` should remain marked as a copy of `src`, but
      this did not previously happen. `matcher` here only includes the files that were
      specified on the commandline, so it only gets the copy information (if any, in
      this example there's not) for `some_unrelated_file.txt`. When it goes to apply
      the memctx to actually create the commit, the file copy information is
      incomplete and loses the information for the files that shouldn't have been
      affected at all by the amend.
      
      Differential Revision: https://phab.mercurial-scm.org/D12625
      df68d64b0d50
    • Kyle Lippincott's avatar
  25. May 04, 2022
  26. Apr 22, 2022
  27. May 04, 2022
Loading