- May 24, 2022
-
-
Pierre-Yves David authored
This is finally making the `obsolete` bundlespec paramater work.
-
- May 17, 2022
-
-
Pierre-Yves David authored
This will open the way for the configuration value to yield in front of the explicit bundle type.
-
Pierre-Yves David authored
They are content using the same keys. Using differents object for access open the gates for confusion in the code using them (this is already the case). So we start fusing their usages to make the parameters more useful. More work will be needed to make them really useful, but the first step is here: not throwing the value away. However this is still not making the previously introduced test useful because currently, the default config value overwrite the one from the bundlespec. We will fix this in the coming changesets.
-
- May 25, 2022
-
-
Pierre-Yves David authored
Narrator voice: Actually it is not. We will fix it in the next changeset.
-
- May 17, 2022
-
-
Pierre-Yves David authored
This is a full new test case and should be "flagged" as such.
-
Pierre-Yves David authored
The handling of the stream case seems fragile (does not account for newer parts and options that will arise) and has special code dedicated to it. To simplify and strengthen things, we make it use the same mechanism as the other options. So we make it less special by making it a special value in the common case.
-
Pierre-Yves David authored
The `_bundlespeccgversions` mapping is redundant with the `cg.version` parameter. We move all users to the `cg.version` version and phase out the `_bundlespeccgversions` mapping.
-
- Jun 13, 2022
-
-
Matt Harbison authored
-
Matt Harbison authored
The comment was wrong- the exception handler was the py3 case.
-
Matt Harbison authored
There was a TortoiseHg bug report in this area[1], and from inspection, it looks like passing `b""` as `valname` would fail to convert to unicode. The underlying API allows both `""` and `NULL` to return the default value for the key. [1] mercurial/tortoisehg/thg#5803
-
- Jun 02, 2022
-
-
Raphaël Gomès authored
-
- May 31, 2022
-
-
Manuel Jacob authored
-
Manuel Jacob authored
In the past, IOError was used to mark a file as removed. The differentiation between OSError and IOError in this place was introduced in e553a425751d, to avoid that “normal” OSErrors / IOErrors accidentally mark files as removed. This weird internal API was removed in 650b5b6e75ed. It seems like that changeset should have removed the differentiation, at least I don’t see any reason for keeping it. On Python 3, OSError and IOError are aliased. Therefore the removed code was actually dead.
-
- Jun 01, 2022
-
-
Manuel Jacob authored
On Python 3, the "not a directory" error is mapped to ENOTDIR instead of EINVAL. Therefore, catching the NotADirectoryError subclass is sufficient.
-
- May 31, 2022
-
-
Manuel Jacob authored
Contrary to the previous changesets in this series, this covers cases where errno was checked for multiple values. EACCES -> PermissionError ENOENT -> FileNotFoundError ENOTDIR -> NotADirectoryError EISDIR -> IsADirectoryError
-
Manuel Jacob authored
-
Manuel Jacob authored
-
Manuel Jacob authored
-
Manuel Jacob authored
-
Manuel Jacob authored
-
Manuel Jacob authored
-
Manuel Jacob authored
-
Manuel Jacob authored
Since the implementation of PEP 475 (Python 3.5), Python retries system calls failing with EINTR. Therefore we don’t need the logic that retries it in Python code.
-
Manuel Jacob authored
-
Manuel Jacob authored
-
Manuel Jacob authored
It seems like the original socket file object is always an io.BufferedIO instance. If not, the code will fail and we should try harder to get the socket object (e.g. if the original socket file object is unbuffered, we can get the `_sock` attribute directly from it).
-
Manuel Jacob authored
-
Manuel Jacob authored
-
- May 29, 2022
-
-
Manuel Jacob authored
On Python 3, file descriptors are already non-inheritable by default.
-
Manuel Jacob authored
-
Manuel Jacob authored
-
- May 31, 2022
-
-
Manuel Jacob authored
I’ve checked that both bytes and str gets passed as the `name` parameter, so the rest of the condition is still required. Because there aren’t really any tests for the extensions, I didn’t want to refactor it to pass a single type.
-
- May 30, 2022
-
-
Manuel Jacob authored
-
- May 29, 2022
-
-
Manuel Jacob authored
The O_CLOEXEC flag is passed by default on Python 3.
-
- May 30, 2022
-
-
Manuel Jacob authored
It accepts str and bytes.
-
Manuel Jacob authored
-
Manuel Jacob authored
-
- May 29, 2022
-
-
Manuel Jacob authored
-
Manuel Jacob authored
-
Manuel Jacob authored
Some code used its own xrange() compatibility code instead of pycompat.xrange().
-