- Nov 12, 2022
-
-
Pierre-Yves David authored
For some unknown reason, `self.lineno` can be None. The previous code crashed in such case, we now ignore the case, as we do for other error in this function. We also fallback to using `-1` in the output when this lack of line number makes it to the display code. The reason of unknown line-numbers is… unknown.
-
- Nov 06, 2022
-
-
Matt Harbison authored
ui.write() expects bytes, and internally uses `b''` as the default when getting the `label` keyword from `*args`. So either we're missing test coverage, or there's some very subtle conversion from unicode somewhere. Also, slip in a type hint to flag this in the future.
-
- Nov 03, 2022
-
-
Raphaël Gomès authored
This is useful for debugging the behavior of the "default" `hg` in tests without having to manually substitute the fallback path.
-
Raphaël Gomès authored
This will be useful for the next patch which needs it.
-
Raphaël Gomès authored
This will make using `rhg` more user-friendly and features more discoverable.
-
Raphaël Gomès authored
This will make using `rhg` more user-friendly and features more discoverable.
-
Raphaël Gomès authored
This makes the output much more readable.
-
- Oct 16, 2022
-
-
Pierre-Yves David authored
Without this change, the perf commands fails within the f67741e8264b::18415fc918a1 range (boundary excluded). Check inline comment for details. With this fix, the command is able to run on this range, with a slightly different behavior (as no revset is "uninlined"). However this is still much better than not being able to run anything in this range. Especially because that range do see some performance regression for unbundle.
-
- Oct 18, 2022
-
-
Pierre-Yves David authored
This makes the next changeset clearer.
-
- Oct 19, 2022
-
-
Jason R. Coombs authored
-
- Nov 03, 2022
-
-
Raphaël Gomès authored
Ellipsis revisions are still experimental and buggy in non-trivial histories. We currently have no plans to improve this situation nor to add support for ellipsis revisions in `rhg`. Falling back should be done carefully (since we may have already done some work that is visible to the user), but in this case it's highly unlikely that we're doing anything useful with a repo with ellipsis revisions, so this should be strictly better, also since the error message is more explicit.
-
- Nov 02, 2022
-
-
Raphaël Gomès authored
Fixes the test introduced in the last changeset. This caused the hash to change, which means that the check in the test had to be adapted. Since this hash is only done as a caching mechanism, invalidation does not pose any backwards compatibility issues.
-
Raphaël Gomès authored
This hash is used for optimizing dirstate `status`. We demonstrate that the hash is incorrectly ignoring the changes to the semantics of the ignore files just because the contents (but not their source) haven't changed. This is fixed in the next changeset.
-
- Nov 03, 2022
-
-
Raphaël Gomès authored
This will be used in the patch fixing the ignore hash collision in dirstate-v2 to check the behavior of the new hashing function.
-
- Oct 19, 2022
-
-
Raphaël Gomès authored
There was a functional race between invalidating the cache (not acted upon until the end of the status algorithm) and populating the new cache (which relies upon an up-to-date version of the cache). We simply inform the cache populating function that we've just invalidated the cache for this particular directory since the information is present in the same scope.
-
Raphaël Gomès authored
-
- Sep 22, 2022
-
-
Arseniy Alekseyev authored
-
- Nov 04, 2022
-
-
Pierre-Yves David authored
Keeping all object open is unsustainable, so we will open them on demand. This mean opening them multiple times, but this is a lesser evil. Each revlog consume a small amount of memory (index content, associated nodemap, etc). While there are few "big" revlog, the sheer amount of small filelog can become a significant issue memory wise, consuming multiple GB of memory. If you combines this extra usage with the use of multiprocessing, this usage can quickly get out of control. This can effectively block the upgrade of larger repository. This changeset fixes this issue.
-
- Nov 02, 2022
-
-
Matt Harbison authored
The default list of ignored modules are str, and test for bypassing the lazy import is `module.__name__ in ignores`, so these were effectively NOT ignored. Most of these date back to the grand byteification in 687b865b95ad, with some subsequent additions that followed the existing example. I have no idea if these modules in fact need to bypass lazy importing, but at least it follows the intent of the code.
-
- Oct 26, 2022
-
-
Raphaël Gomès authored
See previous commit for more details.
-
Raphaël Gomès authored
The Python packer creates unsorted entries in the edge case that a file starts with the same name as a sibling folder. This bug has no effect on the Python `hg status` since Python ignores directories. `rhg` assumes that all on-disk entries are sorted (which is a property of the format) including folder, hence the issue highlighted. This is also technically broken in Rust-augmented `hg status`, but it makes setting up the test more complex than necessary, since it requires the packing to be Python only (which it isn't if you have Rust extensions). Fix is in the next commit.
-
Raphaël Gomès authored
-
Raphaël Gomès authored
-
- Nov 04, 2022
-
-
Raphaël Gomès authored
Despite the best efforts of the comment, this constant wasn't kept in sync when the flags were being rewritten. The fact that this doesn't actually break anything in the Rust implementation too much (which does use directories) relies on the fact that all nodes can have children and that dirstate traversal is not based on that flag, but for metadata in optimizations. However the bug could become more serious should we start encoding stronger guarantees using a combination of flags including this one.
-
- Oct 18, 2022
-
-
Matt Harbison authored
Probably not much more than an minor optimization, but could be useful in the case of `hg verify` where missing blobs are fetched one at a time.
-
Matt Harbison authored
The problem seems to be that the connection used to request the location of the blobs is sitting in the connection pool, and then when workers are forked, they all see and attempt to use the same connection. This garbles everything. I have no clue how this ever worked reliably (but it seems to, even on Linux, with SCM Manager 1.58). See previous discussion when worker support was added[1]. It shouldn't be a problem on Windows, since the workers are just threads in the same process, and can see which connections are marked available and which are in use. (The fact that `mercurial.keepalive.ConnectionManager.set_ready()` doesn't acquire a lock does give me some pause though.) [1] https://phab.mercurial-scm.org/D1568#31621
-
Matt Harbison authored
By default, this just printed the class name and memory address. By displaying the address and ports on both sides of the socket, it makes it easier to figure out what's in the ConnectionManager, and correlate with WireShark traces. It looks like the two connections mentioned in the previous commit come about because the LFS POST request to access the blobs opens connection 1, and gets a 401. Then for some reason, the follow up with credentials opens a new socket, instead of using the existing one in the pool. I have no clue why. This can be seen with something like this in the blobstore: ``` for h in self.urlopener.handlers: if hasattr(h, "close_all"): print('open connections on %s in pid %d' % (type(h), os.getpid())) for host, conns in h._cm.get_all().items(): for c in conns: print('connection: %r' % c) ```
-
Matt Harbison authored
While debugging why LFS blob downloads are getting corrupted with workers, I noticed that prior to spinning up the workers, the ConnectionManager has 2 connections to the server and calling `KeepAliveHandler.close_all()` left one behind. The reason is the value component of `self._cm.get_all().items()` is a list, and `self._cm.remove()` modifies said list while the caller is iterating over it. Now `get_all()` is a deep copy of both the dict and lists in all cases.
-
- Nov 02, 2022
-
-
Matt Harbison authored
Flagged by PyCharm.
-
- Oct 31, 2022
-
-
Arseniy Alekseyev authored
-
Arseniy Alekseyev authored
-
- Oct 24, 2022
-
-
Raphaël Gomès authored
-
Raphaël Gomès authored
-
Raphaël Gomès authored
-
Raphaël Gomès authored
This marks the feature freeze for the 6.3 release
-
- Oct 20, 2022
-
-
Matt Harbison authored
Seen in the wild in a server log when MS antivirus was quarantining a file on the client side.
-
- Oct 19, 2022
-
-
Anton Shestakov authored
-
Anton Shestakov authored
-
Jason R. Coombs authored
-
Jason R. Coombs authored
-