Skip to content
Snippets Groups Projects
  1. May 10, 2022
  2. May 16, 2022
  3. May 04, 2022
  4. May 06, 2022
  5. May 04, 2022
  6. May 08, 2022
  7. May 06, 2022
  8. May 04, 2022
    • Georges Racinet's avatar
      RefService.FindTag: fixed response for unknown tag · 9fa346d4
      Georges Racinet authored
      Nowadays, we have Gitaly Comparison tests to check that kind
      of thing.
      
      The kind of error really suggests that the condition is quite
      unexpected upstream. Probably the client is already fed with
      a correct tag in the first place. Anyway, now we are in sync
      with upstream.
      9fa346d4
    • Georges Racinet's avatar
      tag: uniformized API with hgitaly.branch · e5b53f16
      Georges Racinet authored
      This moves all implementation details from `RefService` to
      `hgitaly.tag`. This has the drawback of resolving change contexts
      even when not needed.
      
      We could improve later by relying on the GitLab tags
      state file, which would guarantee uniformity with what
      the Rails app sees in its pre/post-receive hooks.
      e5b53f16
    • Georges Racinet's avatar
      tag: adopted constant from RefService · d091c0d1
      Georges Racinet authored
      Such implementation details do not belong in a service class.
      d091c0d1
  9. Apr 28, 2022
    • Georges Racinet's avatar
      RepositoryService: implement RemoveRepository · 6e3106e9
      Georges Racinet authored
      Closes #95
      
      This is in advance of the HGitaly3 milestone, but needed for
      gitaly-backup (removal occurs before restoration).
      
      We don't attempt to provide the same level of locking as Gitaly
      does, both because this is not the best time to handle locking
      for mutation methods and because this is a special case, but
      we split the work into atomic rename and cleanup (cheap to
      implement).
      
      See also heptapod#534
      6e3106e9
  10. Apr 29, 2022
    • Georges Racinet's avatar
      test Repository service: using the fixture class pattern · 2abfea4c
      Georges Racinet authored
      In the process, the `ServiceFixture` class gains a few more
      utilities to handle repositories directly and the cleanup code
      paths are now covered.
      
      Also an opportunity to use mercurial_testhelpers features that
      were introduced since the writing of many of these tests,
      such as `LocalRepoWrapper.load()`.
      
      Also applying general coding style that avoids bound variables
      (when reasonable).
      2abfea4c
    • Georges Racinet's avatar
      New fixture base class for service tests · db90846f
      Georges Racinet authored
      This will help make common patterns more uniform.
      The `__init__` super dance is not the most elegant code
      ever written, but using classmethods wouldn't be so much of
      an improvement.
      db90846f
  11. Apr 28, 2022
  12. Oct 09, 2021
  13. Mar 30, 2022
  14. Oct 09, 2021
  15. Aug 28, 2021
  16. Mar 29, 2022
  17. Mar 21, 2022
  18. Mar 20, 2022
    • Georges Racinet's avatar
      Server: fixing keepalive parameter · caa532ac
      Georges Racinet authored
      Despite coincidence between the all caps name used
      in doc with the actual name of the argument in other
      cases, it seems that we need to use the corresponding
      string value in the `#define` for the all caps name.
      
      This is a case where documentation is very lacking
      (didn't find anything explicit about that in API doc
      for Python `grpcio`).
      caa532ac
  19. Mar 14, 2022
  20. Mar 13, 2022
Loading