- Jul 15, 2024
-
-
Clemens Beck authored
Remove the Grafana deprecation message which was accidentally re-added in https://gitlab.com/gitlab-org/omnibus-gitlab/-/merge_requests/7550. Relates https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/8601 Relates https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/8200
-
- Apr 15, 2024
-
-
Balasankar 'Balu' C authored
All the usecases of old RedisHelper has been migrated to NewRedisHelper. Drop the old RedisHelper and rename NewRedisHelper to replace it. Signed-off-by:
Balasankar 'Balu' C <balasankar@gitlab.com>
-
- Apr 08, 2024
-
-
Balasankar 'Balu' C authored
Certain methods in the Redis Helper are to be used in libraries also, where the node object is unavailable. In those scenarios, the methods have to work with the Gitlab object. Make those methods class methods that take a config hash as argument. Also create instance methods with same name, which call these class methods and pass the node object as argument. Signed-off-by:
Balasankar 'Balu' C <balasankar@gitlab.com>
-
- Jun 27, 2024
-
-
Stan Hu authored
Previously including reserved characters such as `@` in the Redis password would fail because `URI::Generic::DEFAULT_PARSER.escape` did not consider `@` unsafe, which it generally isn't per RFC 2396 and 3986. However, the `@` is not allowed in the userinfo field, and the URI builder for Ruby fails if using a reserved character were included. To fix this, use `ERB.url_encode`, which always escapes any non-alphanumeric string. Relates to https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/8602 Changelog: fixed
-
- Jun 24, 2024
-
-
Ian Baum authored
* Creates the gitlab-backup user and groups if they dont' exist * Adds the user to other groups * For use by gitlab-backup-cli for read/write permission to data for backups and restores Changelog: added
-
- Jun 04, 2024
-
-
Clemens Beck authored
The flag postgres_exporter['per_table_stats'] was replaced in favor of postgres_exporter['flags']['collector.stat_user_tables']. Deprecation documentation: https://docs.gitlab.com/ee/update/deprecations.html#postgres_exporterper_table_stats-configuration-setting Changelog: removed Closes https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/8169
-
- May 22, 2024
-
-
Balasankar 'Balu' C authored
Changelog: added Signed-off-by:
Balasankar 'Balu' C <balasankar@gitlab.com>
-
- Apr 18, 2024
-
-
Jaime Martinez authored
Changelog: deprecated
-
- May 21, 2024
-
-
Stan Hu authored
Previously we used `CGI.escape(password)`, but this escapes spaces as `+` instead of `%20`. However, RFC 3986 says the password should be percent-encoded. In fact, while the Ruby Redis client appears to connect fine with the `+`, the Go client doesn't work with that. Update the helper to encode passwords according to RFC 3986. Changelog: fixed
-
- May 15, 2024
-
-
Balasankar 'Balu' C authored
- Moves the Gitlab Rails library to use the new redis helper logic code path. Signed-off-by:
Balasankar 'Balu' C <balasankar@gitlab.com>
-
- May 17, 2024
-
-
Robert Marshall authored
- Grafana was removed in GitLab 16.3. This removes the deprecation messages and the attribute that was left behind to enable those messages to fire without error. Closes https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/8200 Changelog: removed
-
- Apr 26, 2024
-
-
Stan Hu authored
Previously if a Redis instance listened on a UNIX socket but a password were set, GitLab Rails would not be able to authenticate. This occurred because the UNIX URL doesn't contain a password. Both Ruby and Go Redis clients support URLs in the form: unix://<user>:<password>@</path/to/redis.sock>?db=<db_number> Relates to work started in https://gitlab.com/gitlab-org/omnibus-gitlab/-/merge_requests/2194 Changelog: fixed
-
- May 04, 2024
-
-
Gregorius Marco authored
- Eliminates code related to `min_concurrency` and `max_concurrency` options in sidekiq. Related https://gitlab.com/gitlab-com/gl-infra/scalability/-/issues/3422 Changelog: removed
-
- Apr 24, 2024
-
-
Gregorius Marco authored
https://gitlab.com/gitlab-com/gl-infra/scalability/-/issues/2220 Changelog: removed
-
- Apr 15, 2024
-
-
Taka Nishida authored
- Removes code that blocked KAS service when GitLab is deployed in FIPS mode Related https://gitlab.com/gitlab-org/gitlab/-/issues/375327 Changelog: changed
-
- Apr 01, 2024
-
-
Stan Hu authored
As specified in https://redis.io/docs/management/config-file/, Redis can bind to multiple addresses with a space-separated field. Previously attempting to do this without setting `gitlab_rails['redis_host']` would fail because a URI could not be built with a space in the hostname. This commit now splits the string with the space and picks the first address as the default Redis host. Relates to https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/8465 Changelog: added
-
Balasankar 'Balu' C authored
- Continue conversion to the new style redis helper with refactors against the redis server functionality methods Signed-off-by:
Balasankar 'Balu' C <balasankar@gitlab.com>
-
- Mar 27, 2024
-
-
Balasankar 'Balu' C authored
Do not warn if nothing is set and the default empty hash is returned for some configurations. Signed-off-by:
Balasankar 'Balu' C <balasankar@gitlab.com>
-
- Mar 19, 2024
-
-
Robert Marshall authored
- Adds a command to re-apply SELinux file context rules based on the current GitLab provided SELinux policy. - Documents the existence of this new command. - Moves semanage tests into SELinuxHelper rspec and extends coverage for changes made to support the new command. Related https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/7257 Closes https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/7452 Changelog: added Signed-off-by:
Robert Marshall <rmarshall@gitlab.com>
-
- Mar 13, 2024
-
-
Balasankar 'Balu' C authored
Refactor the GitLab Exporter recipe to calculate its redis configuration with the new helper library. Signed-off-by:
Balasankar 'Balu' C <balasankar@gitlab.com>
-
- Mar 12, 2024
-
-
Sami Hiltunen authored
This commit adds a deprecation for 'omnibus_gitconfig'. Git configuration should be directly added under Gitaly's configuration as directed in the linked migration instructions. Configuring Git on a system or user level will no longer be supported through Omnibus. Related https://gitlab.com/gitlab-org/gitaly/-/issues/5132 Changelog: deprecated
-
- Feb 15, 2024
-
-
Robert Marshall authored
- Create a single versioned SELinux policy module for GitLab similar to other policy module components. - The first iteration of the consolidated policy is opt-in if the user sets `package['selinux_policy_version'] to anything other than nil. Closes https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/7453 Closes https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/8235 Changelog: changed Signed-off-by:
Robert Marshall <rmarshall@gitlab.com>
-
- Feb 08, 2024
-
-
Gregorius Marco authored
A new `sidekiq['concurrency']` is added as a simpler option since we dont longer need varying concurrency based on number of queues https://gitlab.com/gitlab-com/gl-infra/scalability/-/issues/2760 Changelog: deprecated
-
- Jan 04, 2024
-
-
Stan Hu authored
This commit adds support for using redis-exporter with an external Redis instance when enabled via: ``` redis_exporter['enable'] = true ``` Omnibus GitLab disables redis-exporter if the bundled Redis instance is disabled, but previously when redis-exporter were enabled it would always attempt to talk to a local UNIX socket. This commit has been tested with Google Memorystore with TLS enabled. Note that TLS client auth is not yet supported.
-
- Dec 12, 2023
-
-
Balasankar 'Balu' C authored
Changelog: deprecated Signed-off-by:
Balasankar 'Balu' C <balasankar@gitlab.com>
-
Balasankar 'Balu' C authored
Signed-off-by:
Balasankar 'Balu' C <balasankar@gitlab.com>
-
- Jan 05, 2024
-
-
Balasankar 'Balu' C authored
Signed-off-by:
Balasankar 'Balu' C <balasankar@gitlab.com>
-
- Dec 12, 2023
-
-
Andrew Patterson authored
Add the generate-secrets command to gitlab-ctl which creates a JSON file containing secrets from the gitlab.rb file. The -f|--file option can be used to send the output to a specified file instead of the default /etc/gitlab/gitlab-secrets.json. Changelog: added
-
- Dec 04, 2023
-
-
Balasankar 'Balu' C authored
Make GitLab Workhorse use the new RedisHelper architecture. Signed-off-by:
Balasankar 'Balu' C <balasankar@gitlab.com>
-
- Nov 23, 2023
-
-
Balasankar "Balu" C authored
Add a new architecture for Redis Helper where each component gets its own class, and a `redis_params` method to provide the Redis related information that is required for it to populate its own config file. Signed-off-by:
Balasankar "Balu" C <balasankar@gitlab.com>
-
- Oct 03, 2023
-
-
Stan Hu authored
When `gitlab-ctl reconfigure` hits an HTTP error while trying to download local cookbooks, the application runs into an `uninitialized constant GitLabHandler::Exception::OmnibusHelper` error: ``` ERROR: Running exception handlers ERROR: Report handler GitLabHandler::Exception raised #<NameError: uninitialized constant GitLabHandler::Exception::OmnibusHelper> ERROR: /opt/gitlab/embedded/cookbooks/package/libraries/handlers/gitlab.rb:30:in `report' ERROR: /opt/gitlab/embedded/lib/ruby/gems/3.0.0/gems/chef-17.10.0/lib/chef/handler.rb:296:in `run_report_unsafe' ERROR: /opt/gitlab/embedded/lib/ruby/gems/3.0.0/gems/chef-17.10.0/lib/chef/handler.rb:284:in `run_report_safely' ERROR: /opt/gitlab/embedded/lib/ruby/gems/3.0.0/gems/chef-17.10.0/lib/chef/handler.rb:155:in `block in run_exception_handlers' ERROR: /opt/gitlab/embedded/lib/ruby/gems/3.0.0/gems/chef-17.10.0/lib/chef/handler.rb:153:in `each' ERROR: /opt/gitlab/embedded/lib/ruby/gems/3.0.0/gems/chef-17.10.0/lib/chef/handler.rb:153:in `run_exception_handlers' ERROR: /opt/gitlab/embedded/lib/ruby/gems/3.0.0/gems/chef-17.10.0/lib/chef/handler.rb:164:in `block in <class:Handler>' ERROR: /opt/gitlab/embedded/lib/ruby/gems/3.0.0/gems/chef-17.10.0/lib/chef/client.rb:443:in `block in run_failed' ERROR: /opt/gitlab/embedded/lib/ruby/gems/3.0.0/gems/chef-17.10.0/lib/chef/client.rb:442:in `each' ERROR: /opt/gitlab/embedded/lib/ruby/gems/3.0.0/gems/chef-17.10.0/lib/chef/client.rb:442:in `run_failed' ERROR: /opt/gitlab/embedded/lib/ruby/gems/3.0.0/gems/chef-17.10.0/lib/chef/client.rb:306:in `rescue in run' ERROR: /opt/gitlab/embedded/lib/ruby/gems/3.0.0/gems/chef-17.10.0/lib/chef/client.rb:299:in `run' ERROR: /opt/gitlab/embedded/lib/ruby/gems/3.0.0/gems/chef-17.10.0/lib/chef/application.rb:305:in `run_with_graceful_exit_option' ERROR: /opt/gitlab/embedded/lib/ruby/gems/3.0.0/gems/chef-17.10.0/lib/chef/application.rb:281:in `block in run_chef_client' ERROR: /opt/gitlab/embedded/lib/ruby/gems/3.0.0/gems/chef-17.10.0/lib/chef/local_mode.rb:42:in `with_server_connectivity' ERROR: /opt/gitlab/embedded/lib/ruby/gems/3.0.0/gems/chef-17.10.0/lib/chef/application.rb:264:in `run_chef_client' ERROR: /opt/gitlab/embedded/lib/ruby/gems/3.0.0/gems/chef-17.10.0/lib/chef/application/base.rb:352:in `run_application' ERROR: /opt/gitlab/embedded/lib/ruby/gems/3.0.0/gems/chef-17.10.0/lib/chef/application.rb:67:in `run' ERROR: /opt/gitlab/embedded/lib/ruby/gems/3.0.0/gems/chef-bin-17.10.0/bin/cinc-client:25:in `<top (required)>' ERROR: /opt/gitlab/embedded/bin/cinc-client:25:in `load' ERROR: /opt/gitlab/embedded/bin/cinc-client:25:in `<main>' ERROR: Exception handlers complete ``` This was seen in https://gitlab.com/gitlab-com/gl-infra/production/-/issues/16897 and raised as a side issue in https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/8245. Changelog: fixed
-
- Sep 18, 2023
-
-
DJ Mountney authored
We will stop building packages for openSUSE 15.4 by GitLab 16.8 Changelog: deprecated
-
- Sep 14, 2023
-
-
Clemens Beck authored
Postgres-exporter 13.0 moved queries from the default queries.yaml to collectors. The newly implemented collectors conflict with the custom queries.yaml from Omnibus, causing errors like: ``` An error has occurred while serving metrics: collected metric pg_replication_is_replica gauge:{value:0} has help "Indicates if the server is a replica" but should have "Indicates if this host is a slave" ``` Upstream MR: https://github.com/prometheus-community/postgres_exporter/pull/801 Closes https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/8164 Closes https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/8112 Changelog: fixed
-
- Sep 05, 2023
-
-
Grant Young authored
No longer required after Grafana removal Changelog: removed
-
- Aug 09, 2023
-
-
Robert Marshall authored
- We no longer need to notify users about gitlab_default_can_create_group as it has been removed for minimally three milestones in 16.x series. Closes https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/7769 Signed-off-by:
Robert Marshall <rmarshall@gitlab.com>
-
- Aug 01, 2023
-
-
Hossein Pursultani authored
Software configuration and related code and documentation are removed from the package. Closes https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/8092 Changelog: removed
-
- Jul 29, 2023
-
-
Balasankar 'Balu' C authored
Signed-off-by:
Balasankar "Balu" C <balasankar@gitlab.com>
-
- Jul 20, 2023
-
-
Suzanne Selhorn authored
Related to: https://gitlab.com/gitlab-org/gitlab/-/issues/384335
-
- Jul 05, 2023
-
-
Robert Marshall authored
Fix GitLab docs link for top-level group settings See merge request https://gitlab.com/gitlab-org/omnibus-gitlab/-/merge_requests/6948 Merged-by:
Robert Marshall <rmarshall@gitlab.com> Approved-by:
Robert Marshall <rmarshall@gitlab.com> Co-authored-by:
Robin Windey <robin.windey@karlstorz.com>
-
Robin Windey authored
- Updates a changed link in the gitlab_default_can_create_group deprecation warning message.
-