Skip to content
Snippets Groups Projects
  1. Jul 15, 2024
  2. Apr 15, 2024
  3. Apr 08, 2024
  4. Jun 27, 2024
    • Stan Hu's avatar
      Fix Redis password handling with reserved characters · ba009e3bf187
      Stan Hu authored
      Previously including reserved characters such as `@` in the Redis
      password would fail because `URI::Generic::DEFAULT_PARSER.escape` did
      not consider `@` unsafe, which it generally isn't per RFC 2396 and
      3986. However, the `@` is not allowed in the userinfo field, and the
      URI builder for Ruby fails if using a reserved character were
      included.
      
      To fix this, use `ERB.url_encode`, which always escapes any
      non-alphanumeric string.
      
      Relates to https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/8602
      
      Changelog: fixed
      ba009e3bf187
  5. Jun 24, 2024
    • Ian Baum's avatar
      Add gitlab-backup user · ab269a7991a2
      Ian Baum authored
      * Creates the gitlab-backup user and groups if they dont' exist
      * Adds the user to other groups
      * For use by gitlab-backup-cli for read/write permission to data for
        backups and restores
      
      Changelog: added
      ab269a7991a2
  6. Jun 04, 2024
  7. May 22, 2024
  8. Apr 18, 2024
  9. May 21, 2024
    • Stan Hu's avatar
      redis: Fix handling of passwords with a space · 191ff5a0879a
      Stan Hu authored
      Previously we used `CGI.escape(password)`, but this escapes spaces as
      `+` instead of `%20`. However, RFC 3986 says the password should be
      percent-encoded. In fact, while the Ruby Redis client appears to
      connect fine with the `+`, the Go client doesn't work with that.
      Update the helper to encode passwords according to RFC 3986.
      
      Changelog: fixed
      191ff5a0879a
  10. May 15, 2024
  11. May 17, 2024
  12. Apr 26, 2024
  13. May 04, 2024
  14. Apr 24, 2024
  15. Apr 15, 2024
  16. Apr 01, 2024
  17. Mar 27, 2024
  18. Mar 19, 2024
  19. Mar 13, 2024
  20. Mar 12, 2024
  21. Feb 15, 2024
  22. Feb 08, 2024
  23. Jan 04, 2024
    • Stan Hu's avatar
      Make redis-exporter work with external Redis instances · 9a137957310c
      Stan Hu authored
      This commit adds support for using redis-exporter with an
      external Redis instance when enabled via:
      
      ```
      redis_exporter['enable'] = true
      ```
      
      Omnibus GitLab disables redis-exporter if the bundled Redis instance
      is disabled, but previously when redis-exporter were enabled it
      would always attempt to talk to a local UNIX socket.
      
      This commit has been tested with Google Memorystore with TLS enabled.
      Note that TLS client auth is not yet supported.
      9a137957310c
  24. Dec 12, 2023
  25. Jan 05, 2024
  26. Dec 12, 2023
    • Andrew Patterson's avatar
      Add gitlab-ctl generate-secrets command · 878e283a5318
      Andrew Patterson authored
      Add the generate-secrets command to gitlab-ctl which creates a JSON file
      containing secrets from the gitlab.rb file. The -f|--file option can
      be used to send the output to a specified file instead of the default
      /etc/gitlab/gitlab-secrets.json.
      
      Changelog: added
      878e283a5318
  27. Dec 04, 2023
  28. Nov 23, 2023
  29. Oct 03, 2023
    • Stan Hu's avatar
      Fix unintialized constant exception handler error · 69f2fd6a849a
      Stan Hu authored
      When `gitlab-ctl reconfigure` hits an HTTP error while trying to
      download local cookbooks, the application runs into an `uninitialized
      constant GitLabHandler::Exception::OmnibusHelper` error:
      
      ```
      ERROR: Running exception handlers
      ERROR: Report handler GitLabHandler::Exception raised #<NameError: uninitialized constant GitLabHandler::Exception::OmnibusHelper>
      ERROR: /opt/gitlab/embedded/cookbooks/package/libraries/handlers/gitlab.rb:30:in `report'
      ERROR: /opt/gitlab/embedded/lib/ruby/gems/3.0.0/gems/chef-17.10.0/lib/chef/handler.rb:296:in `run_report_unsafe'
      ERROR: /opt/gitlab/embedded/lib/ruby/gems/3.0.0/gems/chef-17.10.0/lib/chef/handler.rb:284:in `run_report_safely'
      ERROR: /opt/gitlab/embedded/lib/ruby/gems/3.0.0/gems/chef-17.10.0/lib/chef/handler.rb:155:in `block in run_exception_handlers'
      ERROR: /opt/gitlab/embedded/lib/ruby/gems/3.0.0/gems/chef-17.10.0/lib/chef/handler.rb:153:in `each'
      ERROR: /opt/gitlab/embedded/lib/ruby/gems/3.0.0/gems/chef-17.10.0/lib/chef/handler.rb:153:in `run_exception_handlers'
      ERROR: /opt/gitlab/embedded/lib/ruby/gems/3.0.0/gems/chef-17.10.0/lib/chef/handler.rb:164:in `block in <class:Handler>'
      ERROR: /opt/gitlab/embedded/lib/ruby/gems/3.0.0/gems/chef-17.10.0/lib/chef/client.rb:443:in `block in run_failed'
      ERROR: /opt/gitlab/embedded/lib/ruby/gems/3.0.0/gems/chef-17.10.0/lib/chef/client.rb:442:in `each'
      ERROR: /opt/gitlab/embedded/lib/ruby/gems/3.0.0/gems/chef-17.10.0/lib/chef/client.rb:442:in `run_failed'
      ERROR: /opt/gitlab/embedded/lib/ruby/gems/3.0.0/gems/chef-17.10.0/lib/chef/client.rb:306:in `rescue in run'
      ERROR: /opt/gitlab/embedded/lib/ruby/gems/3.0.0/gems/chef-17.10.0/lib/chef/client.rb:299:in `run'
      ERROR: /opt/gitlab/embedded/lib/ruby/gems/3.0.0/gems/chef-17.10.0/lib/chef/application.rb:305:in `run_with_graceful_exit_option'
      ERROR: /opt/gitlab/embedded/lib/ruby/gems/3.0.0/gems/chef-17.10.0/lib/chef/application.rb:281:in `block in run_chef_client'
      ERROR: /opt/gitlab/embedded/lib/ruby/gems/3.0.0/gems/chef-17.10.0/lib/chef/local_mode.rb:42:in `with_server_connectivity'
      ERROR: /opt/gitlab/embedded/lib/ruby/gems/3.0.0/gems/chef-17.10.0/lib/chef/application.rb:264:in `run_chef_client'
      ERROR: /opt/gitlab/embedded/lib/ruby/gems/3.0.0/gems/chef-17.10.0/lib/chef/application/base.rb:352:in `run_application'
      ERROR: /opt/gitlab/embedded/lib/ruby/gems/3.0.0/gems/chef-17.10.0/lib/chef/application.rb:67:in `run'
      ERROR: /opt/gitlab/embedded/lib/ruby/gems/3.0.0/gems/chef-bin-17.10.0/bin/cinc-client:25:in `<top (required)>'
      ERROR: /opt/gitlab/embedded/bin/cinc-client:25:in `load'
      ERROR: /opt/gitlab/embedded/bin/cinc-client:25:in `<main>'
      ERROR: Exception handlers complete
      ```
      
      This was seen in
      https://gitlab.com/gitlab-com/gl-infra/production/-/issues/16897 and
      raised as a side issue in
      https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/8245.
      
      Changelog: fixed
      69f2fd6a849a
  30. Sep 18, 2023
  31. Sep 14, 2023
  32. Sep 05, 2023
  33. Aug 09, 2023
  34. Aug 01, 2023
  35. Jul 29, 2023
  36. Jul 20, 2023
  37. Jul 05, 2023
Loading