Skip to content
Snippets Groups Projects
  1. Dec 04, 2024
  2. Apr 15, 2024
  3. Apr 10, 2024
  4. Jan 11, 2024
  5. Jan 05, 2024
  6. Oct 03, 2023
  7. Oct 17, 2023
  8. Sep 29, 2023
  9. Aug 09, 2023
  10. Jun 15, 2023
  11. Jun 14, 2023
    • Stan Hu's avatar
      Support password authentication for Redis Sentinel · 40d4a733762f
      Stan Hu authored
      This commit adds a separate password parameter for each Sentinel group
      and enables GitLab Rails, Workhorse, and `gitlab-kas` to use a
      password specified in `requirepass` in the Sentinel configuration:
      
      ```ruby
      gitlab_rails['redis_sentinels_password']
      gitlab_rails['redis_cache_sentinels_password']
      gitlab_rails['redis_queues_sentinels_password']
      gitlab_rails['redis_shared_state_sentinels_password']
      gitlab_rails['redis_trace_chunks_sentinels_password']
      gitlab_rails['redis_actioncable_sentinels_password']
      gitlab_rails['redis_rate_limiting_sentinels_password']
      gitlab_rails['redis_sessions_sentinels_password']
      gitlab_rails['redis_cluster_rate_limiting_sentinels_password']
      gitlab_rails['redis_repository_cache_sentinels_password']
      ```
      
      We could avoid these extra configuration parameters by having the
      admin specify a `password` parameter for each host/port combination in
      `redis_sentinels`, `redis_cache_sentinels`, etc. However, this would
      add much duplication in the configuration and different passwords
      aren't actually supported by Redis Sentinel. gitlab-kas also expects a
      single Sentinel password stored in the `sentinel_password_file`
      configuration parameter.
      
      Relates to https://gitlab.com/gitlab-org/gitlab/-/issues/235938
      
      Changelog: added
      40d4a733762f
  12. May 04, 2023
  13. Apr 28, 2023
  14. Apr 06, 2023
  15. Mar 28, 2023
  16. Mar 13, 2023
  17. Mar 07, 2023
  18. Mar 13, 2023
    • Pam Artiaga's avatar
      Support dedicated sub-domain for kas · 63658d614255
      Pam Artiaga authored
      Support the use of a dedicated sub-domain for the
      GitLab Agent Server (KAS) address by setting the kas url
      through the `gitlab_kas_external_url` configuration.
      
      Changelog: changed
      63658d614255
  19. Jun 30, 2022
  20. May 02, 2022
    • Hordur Freyr Yngvason's avatar
      Add observability listener configuration for KAS · d859c01f5454
      Hordur Freyr Yngvason authored
      By default, this server listens only on localhost. But when using an
      external load balancer, the server needs to accept connections from the
      load balancer for health checks (for example, by by listening on
      0.0.0.0).
      
      Changelog: added
      d859c01f5454
  21. Apr 15, 2022
  22. Mar 02, 2022
  23. Feb 11, 2022
  24. Jan 09, 2022
    • Fabio Huser's avatar
      Add sentry configuration options for GitLab KAS · fcfeb7c6b533
      Fabio Huser authored
      This commit adds new `gitlab_kas['sentry_dsn']` and `gitlab_kas['sentry_environment']`
      configuration options, allowing to enable Sentry error tracking for GitLab KAS.
      It supports setting the Sentry DSN as well as an optional environment, as it's
      also the case for other GitLab services.
      
      Changelog: added
      fcfeb7c6b533
    • Fabio Huser's avatar
      Correct GitLab KAS default redis port configuration · e4741d6c015c
      Fabio Huser authored
      Using gitlab-kas with an external redis instance (`gitlab_rails['redis_host']`
      set to e.g. `my-redis`) but default port configuration (`gitlab_rails['redis_port']`
      not set) leads to an invalid redis hostname/port combination (e.g. `my-redis:`
      instead of `my-redis:6379`). This configuration works perfectly fine for other
      GitLab services (e.g. workhorse, gitlab-rails) and is also covered by unit-tests
      (see spec/libraries/redis_helper_spec.rb#59). Those services rely on the
      `redis_url` method which properly omits the default redis port completely,
      whereas gitlab-kas derives the hostname/port combination from the two values
      directly but not taking a default port value into account. This commit changes
      that behavior by adding a fall-back default redis port, in case no custom one is
      set and the tcp connection method is used.
      
      Changelog: fixed
      e4741d6c015c
  25. Jan 08, 2022
    • Fabio Huser's avatar
      Sync trailing slash usage for GitLab KAS routes · 683d846bcd3e
      Fabio Huser authored
      The GitLab Nginx templates uses the non-changeable routes `-/kubernetes-agent/`
      and `-/kubernetes-agent/k8s-proxy/` for KAS/KAS K8s API proxy forwarding.
      Both routes use trailing slashes while the GitLab rails configuration by default
      generates routes without trailing slashes. This will cause GitLab to generate a
      KAS configuration with invalid target URL, causing a connection failure as the
      server returns a HTTP 301 instead of 101. This commit syncs the temples to
      consistently using a trailing slash. Besides that, two other minor points
      were addressed:
      
      - The `gitlab_kas_external_k8s_proxy_url` example in `gitlab.rb.template`
        wrongly used the `wss://` schema but is in fact a reverse proxy for a K8s API.
        This was corrected to use `https://` instead.
      - The inline comment in `gitlab_kas.rb` used a wrong path reference. This was
        corrected as well
      
      Changelog: fixed
      683d846bcd3e
  26. Dec 07, 2021
  27. Sep 22, 2021
  28. Nov 08, 2021
  29. Mar 12, 2021
  30. Jan 28, 2021
  31. Dec 07, 2020
  32. Nov 11, 2020
  33. Oct 08, 2020
Loading