Skip to content
Snippets Groups Projects
Commit 32b0304d authored by Georges Racinet's avatar Georges Racinet
Browse files

RHGitaly: avoid logging all metadata

Logging all invocation metadata is verbose and contains secrets
(authentication header). Of these, only the `correlation_id` is
interesting to us at the moment.

To achieve this, we split the service method with an inner method
taking the inner request and the correlation id. Only the inner
method is now instrumented.

This is heavy for the implementation.
We tried not to split, using the `fields` modifier like this:

```
    #[instrument(skip(self, request), fields(request = request.get_ref()))]
```

and it ended up giving "`RepositoryRequest` does not implement tracing::Value`"

The splitting will be good enough for now.
parent dee21e96
No related branches found
No related tags found
2 merge requests!151heptapod#743: making 0.36 the new stable,!147RHGitaly: avoid logging all metadata
Pipeline #66130 passed
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment